Quick pass at burning down KCL-P&C drift#12314
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
pierremtb
commented
Jul 3, 2026
pierremtb
changed the title
auto-merge was automatically disabled
July 3, 2026 18:32
Pull request was converted to draft
Contributor
Author
|
Need to fix Rotate.angle before marking ready |
pierremtb
commented
Jul 3, 2026
Comment on lines
+265
to
+282
| function extractRequiredStringArgument( | ||
| code: string, | ||
| operation: StdLibCallOp, | ||
| argName: string | ||
| ): string | { error: string } { | ||
| const arg = operation.labeledArgs?.[argName] | ||
| if (!arg?.sourceRange) { | ||
| return { error: `Missing or invalid ${argName} argument` } | ||
| } | ||
|
|
||
| const value = code.slice(...arg.sourceRange.map((r) => toUtf16(r, code))) | ||
| if (!value) { | ||
| return { error: `Couldn't retrieve ${argName} argument` } | ||
| } | ||
|
|
||
| return value | ||
| } | ||
|
|
Contributor
Author
There was a problem hiding this comment.
Made this to make Patterns and Rotate.axis consistent!
Contributor
this one aint working
|
max-mrgrsk
approved these changes
Jul 4, 2026
Contributor
Author
As discussed on Slack this isn't an issue with this PR, let's bring all Pattern3D.axis and Rotate.axis to support this in a stacked PR at #12337 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented a pass that removes the low-risk
omittedStdLibArgsand threads them through P&C submit/edit paths.Burned down:
Extrude.directionSweep/Loft/Revolve/FillettoleranceTranslate.xyzRotate.axis/Rotate.angleSubtract/Union/IntersecttoleranceJoin Surfaces.toleranceLeft intentionally omitted because they’re structural selection-derived args, not simple KCL fields:
Shell.solidsHole.solidFillet/Chamfer.solidand rawedgesDelete Face.body/faceIndicesAlso updated edit-flow extraction so existing KCL with these args preserves them, and added targeted edit-flow coverage for
Extrude.directionandSweep.tolerance.