edge extrudes compat with face api#12465
Draft
Irev-Dev wants to merge 3 commits into
Draft
Conversation
…ecifiers # Conflicts: # rust/Cargo.lock # rust/kcl-lib/src/execution/artifact.rs
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Anything in KCL that refers to an edge needs to accept the face API edge-specifier payload to work with the upcoming face API. This updates
extrudeso its input edge or optionaldirectioncan usesideFaces, optionalendFaces, and an optionalindex, without first resolving the edge to a UUID with another engine command.This follows the shared edge-specifier path used by the other face API work. KCL resolves face tags into the payload expected by the engine and sends it directly as
targetReferenceordirectionReference. Existing sketches, faces, tagged edges, segments, UUID-backed edges, and point directions keep their current behavior.There are a few intentional restrictions:
extrudecall.toalready accepts edge specifiers when extruding a normal UUID-backed target. What is not supported is using an edge specifier as the target being extruded together withto, becauseExtrudeToReferencestill requires that source target to have a UUID. Twist extrusion has the same source-target limitation.targetReferenceinstead of a path UUID. The artifact graph therefore cannot mark a specific path artifact as consumed until the engine resolves that reference, so it leaves that source-path relationship empty instead of attaching it to the wrong edge.Related PRs:
The modeling API and compatibility changes have merged. This end-to-end KCL change should land alongside but after the engine implementation.