Use Uri facade instead of parse_url for host extraction

- Simplify get_github_api_url with if/else and Str::replaceFirst

Author: arhowe00

app/Utils/RepositoryUtils.php

@@ -10,6 +10,8 @@
 use CDash\Model\Project;
 use CDash\ServiceContainer;
 use Illuminate\Support\Facades\Log;
+use Illuminate\Support\Str;
+use Illuminate\Support\Uri;
 use PDO;
 
 class RepositoryUtils
@@ -27,7 +29,7 @@ public static function isGitHubUrl(string $url): bool
         }
         $enterpriseUrl = self::getEnterpriseUrl();
         if ($enterpriseUrl !== null) {
-            $host = parse_url($enterpriseUrl, PHP_URL_HOST);
+            $host = Uri::of($enterpriseUrl)->host();
             return is_string($host) && str_contains($url, $host);
         }
         return false;
@@ -162,36 +164,22 @@ public static function post_pull_request_comment($projectid, $pull_request, $com
         }
     }
 
-    /** Convert GitHub repository viewer URL into corresponding API URL. */
-    public static function get_github_api_url($github_url): string
+    /**
+     * Convert a GitHub repository viewer URL (e.g. https://<host>/<user>/<repo>)
+     * into the corresponding REST API URL.
+     */
+    public static function get_github_api_url(string $github_url): string
     {
         $enterpriseUrl = self::getEnterpriseUrl();
-        if ($enterpriseUrl !== null) {
-            $host = parse_url($enterpriseUrl, PHP_URL_HOST);
-            if (is_string($host)) {
-                $idx = strpos($github_url, $host);
-                if ($idx !== false) {
-                    // For GHE, ...://<host>/<user>/<repo> becomes ...://<host>/api/v3/repos/<user>/<repo>
-                    $idx2 = $idx + strlen($host) + 1;
-                    $api_url = substr($github_url, 0, $idx) . $host . '/api/v3/repos/';
-                    $api_url .= substr($github_url, $idx2);
-                    return $api_url;
-                }
-            }
+        $host = $enterpriseUrl !== null ? Uri::of($enterpriseUrl)->host() : null;
+
+        if (is_string($host) && str_contains($github_url, $host)) {
+            // GHE uses <host>/api/v3/repos/ as the API base
+            return Str::replaceFirst($host . '/', $host . '/api/v3/repos/', $github_url);
+        } else {
+            // GitHub.com uses api.github.com/repos/ as the API base
+            return Str::replaceFirst('github.com/', 'api.github.com/repos/', $github_url);
         }
-        /*
-         * For a URL of the form:
-         * ...://github.com/<user>/<repo>
-         * We return:
-         * ...://api.github.com/repos/<user>/<repo>
-         */
-        $idx1 = strpos($github_url, 'github.com');
-        $idx2 = $idx1 + strlen('github.com/');
-        $api_url = substr($github_url, 0, $idx2);
-        $api_url = str_replace('github.com', 'api.github.com', $api_url);
-        $api_url .= 'repos/';
-        $api_url .= substr($github_url, $idx2);
-        return $api_url;
     }
 
     public static function post_github_pull_request_comment(Project $project, $pull_request, $comment, $cdash_url): void