Revamp /builds/<id>/configure (#3262)

This PR continues our ongoing effort to modernize the site, completely
rethinking the design of `/builds/<id>/configure`. Like most of the
recent refactors, this PR deprecates the API endpoint used by the legacy
page in favor of the new GraphQL API.

Example for builds without subprojects or all-at-once builds where all
child builds share a configure:
<img width="2834" height="1386" alt="image"
src="https://github.com/user-attachments/assets/be7c98dd-d850-4ea4-8fcc-8200a681d3aa"
/>


Example for subproject builds with separate configures for each build:
<img width="2832" height="1518" alt="image"
src="https://github.com/user-attachments/assets/85154d9c-9e83-4dbf-b2b6-576a5697eaf4"
/>

Author: williamjallen

app/Http/Controllers/BuildController.php

@@ -62,7 +62,9 @@ public function configure(int $build_id): View
     {
         $this->setBuildById($build_id);
 
-        return $this->vue('build-configure', 'Configure', [], false);
+        return $this->vue('build-configure', 'Configure', [
+            'build-id' => $this->build->Id,
+        ]);
     }
 
     public function notes(int $build_id): View
@@ -1022,6 +1024,7 @@ public function apiViewConfigure(): JsonResponse
         $this->setBuildById((int) $_GET['buildid']);
 
         $response = begin_JSON_response();
+        $response['deprecated'] = 'This endpoint will be removed in the next major version of CDash.';
 
         $date = TestingDay::get($this->project, $this->build->StartTime);
         get_dashboard_JSON($this->project->Name, $date, $response);

app/Models/Configure.php

@@ -2,7 +2,9 @@
 
 namespace App\Models;
 
+use Database\Factories\ConfigureFactory;
 use Illuminate\Database\Eloquent\Builder;
+use Illuminate\Database\Eloquent\Factories\HasFactory;
 use Illuminate\Database\Eloquent\Model;
 use Illuminate\Database\Eloquent\Relations\HasManyThrough;
 
@@ -18,6 +20,9 @@
  */
 class Configure extends Model
 {
+    /** @use HasFactory<ConfigureFactory> */
+    use HasFactory;
+
     protected $table = 'configure';
 
     public $timestamps = false;

app/cdash/app/Model/Build.php

@@ -700,8 +700,8 @@ public function GetConfigures(): PDOStatement|false
                            b.configureerrors, b.configurewarnings
                     FROM configure c
                     JOIN build2configure b2c ON b2c.configureid = c.id
-                    JOIN subproject sp ON sp.id = b.subprojectid
                     JOIN build b ON b.id = b2c.buildid
+                    JOIN subproject sp ON sp.id = b.subprojectid
                     WHERE b.parentid = ?');
             } elseif (count($configure_rows) === 1) {
                 // One configure row is shared by all the SubProjects.

app/cdash/tests/CMakeLists.txt

@@ -212,6 +212,8 @@ set_property(TEST /Feature/GraphQL/SiteTypeTest APPEND PROPERTY RUN_SERIAL TRUE)
 
 add_feature_test(/Feature/GraphQL/BuildTypeTest)
 
+add_feature_test(/Feature/GraphQL/ConfigureTypeTest)
+
 add_feature_test(/Feature/GraphQL/TestTypeTest)
 
 add_feature_test(/Feature/GraphQL/TestMeasurementTypeTest)
@@ -349,6 +351,8 @@ add_browser_test(/Browser/Pages/BuildTargetsPageTest)
 
 add_browser_test(/Browser/Pages/BuildTestsPageTest)
 
+add_browser_test(/Browser/Pages/BuildConfigurePageTest)
+
 add_php_test(image)
 set_tests_properties(image PROPERTIES DEPENDS /CDash/XmlHandler/UpdateHandler)
 

database/factories/ConfigureFactory.php

@@ -0,0 +1,39 @@
+<?php
+
+namespace Database\Factories;
+
+use App\Models\Configure;
+use Illuminate\Database\Eloquent\Factories\Factory;
+use Illuminate\Support\Str;
+use Random\RandomException;
+
+/**
+ * @extends Factory<Configure>
+ */
+class ConfigureFactory extends Factory
+{
+    /**
+     * Define the model's default state.
+     *
+     * @return array<string, mixed>
+     *
+     * @throws RandomException
+     */
+    public function definition(): array
+    {
+        return [
+            'command' => Str::uuid()->toString(),
+            'log' => Str::uuid()->toString(),
+            'status' => 0,
+            'warnings' => 0,
+            'crc32' => random_int(0, 1000000),
+        ];
+    }
+
+    public function withWarnings(int $numWarnings): static
+    {
+        return $this->state(fn (array $attributes) => [
+            'warnings' => $numWarnings,
+        ]);
+    }
+}

graphql/schema.graphql

@@ -367,6 +367,19 @@ type RemoveUserMutationPayload implements MutationPayloadInterface {
 }
 
 
+"Configure."
+type Configure {
+  "Unique primary key."
+  id: ID! @filterable
+
+  command: String! @filterable
+
+  log: String! @filterable
+
+  returnValue: Int! @rename(attribute: "status") @filterable
+}
+
+
 "Build."
 type Build {
   "Unique primary key."
@@ -512,6 +525,8 @@ type Build {
   files: [UploadedFile!]! @hasMany(relation: "uploadedFiles", type: CONNECTION, scopes: ["files"]) @orderBy(column: "id", direction: ASC)
 
   subProject: SubProject! @belongsTo
+
+  configure: Configure @hasOneThrough
 }