Remove "compare coverage" page (#3617)

The little-used coverage comparison page has been broken on and off for
many years, and I'm currently in the process of implementing replacement
functionality. This PR strips out all of the old code in preparation for
that work.

Author: williamjallen

app/Http/Controllers/CoverageController.php

@@ -122,15 +122,13 @@ private static function getFiltersForPage(string $page_id): array
                 'subproject',
                 'testname',
             ],
-            'compareCoverage.php' => ['subproject'],
             default => [],
         };
     }
 
     private static function isDatePage(string $page_id): bool
     {
         switch ($page_id) {
-            case 'compareCoverage.php':
             case 'index.php':
             case 'indexchildren.php':
             case 'project.php':

app/Http/Controllers/FilterController.php

@@ -436,34 +436,6 @@ public function getSqlField($field): string
     }
 }
 
-class CompareCoveragePhpFilters extends DefaultFilters
-{
-    public function getDefaultFilter(): array
-    {
-        return [
-            'field' => 'subproject',
-            'fieldtype' => 'string',
-            'compare' => 61,
-            'value' => '',
-        ];
-    }
-
-    public function getSqlField($field): string
-    {
-        $sql_field = '';
-        switch (strtolower($field)) {
-            case 'subproject':
-                $sql_field = 'sp.name';
-                break;
-
-            default:
-                trigger_error("unknown field: $field", E_USER_WARNING);
-                break;
-        }
-        return $sql_field;
-    }
-}
-
 class TestOverviewPhpFilters extends DefaultFilters
 {
     public function getDefaultFilter(): array
@@ -524,10 +496,6 @@ function createPageSpecificFilters($page_id)
             return new TestOverviewPhpFilters();
             break;
 
-        case 'compareCoverage.php':
-            return new CompareCoveragePhpFilters();
-            break;
-
         default:
             trigger_error('unknown $page_id value: ' . $page_id .
                 ' Add a new subclass of DefaultFilters for ' . $page_id,

app/cdash/include/filterdataFunctions.php

@@ -190,107 +190,6 @@ public function testVerifyResults()
         return $success;
     }
 
-    public function testCompareCoverage(): void
-    {
-        $answers = [
-            'Total' => [
-                'debug' => 68.97,
-                'release' => 51.35,
-                'aggregate' => 72.97],
-            'Third Party' => [
-                'debug' => 100,
-                'release' => 53.85,
-                'aggregate' => 69.23],
-            'Experimental' => [
-                'debug' => 62.5,
-                'release' => 50,
-                'aggregate' => 75],
-            'Production' => [
-                'debug' => 62.5,
-                'release' => 50,
-                'aggregate' => 75]];
-        $this->compareCoverageCheck('', $answers);
-    }
-
-    public function testCompareCoverageWithFilters(): void
-    {
-        $extra_url = '&filtercount=1&showfilters=1&field1=subproject&compare1=62&value1=MyReleaseOnlyFeature';
-        $answers = [
-            'Total' => [
-                'debug' => 68.97,
-                'release' => 51.72,
-                'aggregate' => 79.31],
-            'Third Party' => [
-                'debug' => 100,
-                'release' => 60,
-                'aggregate' => 100],
-            'Experimental' => [
-                'debug' => 62.5,
-                'release' => 50,
-                'aggregate' => 75],
-            'Production' => [
-                'debug' => 62.5,
-                'release' => 50,
-                'aggregate' => 75]];
-        $this->compareCoverageCheck($extra_url, $answers);
-    }
-
-    public function compareCoverageCheck($extra_url, $answers): void
-    {
-        // Load test data from API.
-        $this->get($this->url . "/api/v1/compareCoverage.php?project=CrossSubProjectExample&date=2016-02-16$extra_url");
-        $content = $this->getBrowser()->getContent();
-        $jsonobj = json_decode($content, true);
-
-        // Verify correct number of builds.
-        $num_builds = count($jsonobj['builds']);
-        if ($num_builds !== 3) {
-            $this->fail("Expected 3 builds, found $num_builds");
-        }
-
-        // Figure out how to distinguish between our coverage builds.
-        $builds = [];
-        foreach ($jsonobj['builds'] as $build) {
-            switch ($build['name']) {
-                case 'debug_coverage':
-                    $builds['debug'] = $build['key'];
-                    break;
-                case 'release_coverage':
-                    $builds['release'] = $build['key'];
-                    break;
-                case 'Aggregate Coverage':
-                    $builds['aggregate'] = $build['key'];
-                    break;
-                default:
-                    $this->fail('Unexpected build: ' . $build['name']);
-                    break;
-            }
-        }
-
-        // Verify number of groups.
-        $num_groups = count($jsonobj['coveragegroups']);
-        if ($num_groups !== 4) {
-            $this->fail("Expected 4 coveragegroups, found $num_groups");
-        }
-
-        // Verify coverage percentage numbers.
-        foreach ($jsonobj['coveragegroups'] as $group) {
-            $groupname = $group['label'];
-            if (!array_key_exists($groupname, $answers)) {
-                $this->fail("Unexpected group: $groupname");
-                continue;
-            }
-
-            foreach ($builds as $buildtype => $key) {
-                $expected = $answers[$groupname][$buildtype];
-                $found = $group[$key];
-                if ($expected !== $found) {
-                    $this->fail("Expected $expected but found $found for $buildtype $groupname");
-                }
-            }
-        }
-    }
-
     public function checkCoverage($coverage, $expected_loctested,
         $expected_locuntested, $expected_percentage,
         $name)