Remove deprecated /api/v1/viewDynamicAnalysisFile.php endpoint (#3624)

Author: williamjallen

app/Http/Controllers/DynamicAnalysisController.php

@@ -179,71 +179,6 @@ public function apiViewDynamicAnalysis(): JsonResponse
         return response()->json(cast_data_for_JSON($response));
     }
 
-    public function apiViewDynamicAnalysisFile(): JsonResponse
-    {
-        $pageTimer = new PageTimer();
-
-        // Make sure a valid id was specified.
-        if (!isset($_GET['id']) || !is_numeric($_GET['id'])) {
-            abort(400, 'Not a valid id!');
-        }
-        $id = $_GET['id'];
-        $DA = new DynamicAnalysis();
-        $DA->Id = $id;
-        if (!$DA->Fill()) {
-            abort(400, 'Not a valid id!');
-        }
-
-        // Get the build associated with this analysis.
-        $this->setBuildById($DA->BuildId);
-
-        $date = TestingDay::get($this->project, $this->build->StartTime);
-        $response = begin_JSON_response();
-        get_dashboard_JSON($this->project->Name, $date, $response);
-        $response['title'] = "{$this->project->Name} - Dynamic Analysis";
-
-        // Build
-        $build_response = [];
-        $build_response['site'] = $this->build->GetSite()->name;
-        $build_response['buildname'] = $this->build->Name;
-        $build_response['buildid'] = $this->build->Id;
-        $build_response['buildtime'] = $this->build->StartTime;
-        $response['build'] = $build_response;
-
-        // Menu
-        $menu_response = [];
-        $menu_response['back'] = "/builds/{$this->build->Id}/dynamic_analysis";
-        $previous_id = $DA->GetPreviousId($this->build);
-        if ($previous_id > 0) {
-            $menu_response['previous'] = "viewDynamicAnalysisFile.php?id=$previous_id";
-        } else {
-            $menu_response['previous'] = false;
-        }
-        $current_id = $DA->GetLastId($this->build);
-        $menu_response['current'] = "viewDynamicAnalysisFile.php?id=$current_id";
-        $next_id = $DA->GetNextId($this->build);
-        if ($next_id > 0) {
-            $menu_response['next'] = "viewDynamicAnalysisFile.php?id=$next_id";
-        } else {
-            $menu_response['next'] = false;
-        }
-        $response['menu'] = $menu_response;
-
-        // dynamic analysis
-        $DA_response = [];
-        $DA_response['status'] = ucfirst($DA->Status);
-        $DA_response['filename'] = $DA->Name;
-        // Only display the first 1MB of the log (in case it's huge)
-        $DA_response['log'] = substr($DA->Log, 0, 1024 * 1024);
-        $DA_response['href'] = "queryTests.php?project={$this->project->Name}&filtercount=1&showfilters=1&field1=testname&compare1=61&value1={$DA->Name}&date={$this->date}";
-        $response['dynamicanalysis'] = $DA_response;
-
-        $response['deprecated'] = 'This endpoint will be removed in the next major version of CDash.';
-
-        $pageTimer->end($response);
-        return response()->json(cast_data_for_JSON($response));
-    }
-
     /**
      * Get the previous build id dynamicanalysis
      */

app/cdash/tests/test_viewdynamicanalysisfile.php

@@ -18,13 +18,6 @@ public function __construct()
         parent::__construct();
     }
 
-    public function testViewDynamicAnalysisFile(): void
-    {
-        $response = $this->get($this->url . '/api/v1/viewDynamicAnalysisFile.php?id=1');
-        $response = json_decode($response);
-        $this->assertTrue(property_exists($response, 'dynamicanalysis'));
-    }
-
     public function testNextPrevious(): void
     {
         // Get id of existing build.

phpstan-baseline.neon

@@ -1140,7 +1140,7 @@ parameters:
 		-
 			rawMessage: Cannot access property $name on App\Models\Site|null.
 			identifier: property.nonObject
-			count: 2
+			count: 1
 			path: app/Http/Controllers/DynamicAnalysisController.php
 
 		-
@@ -25134,12 +25134,6 @@ parameters:
 			count: 1
 			path: app/cdash/tests/test_viewdynamicanalysisfile.php
 
-		-
-			rawMessage: 'Parameter #1 $object_or_class of function property_exists expects object|string, mixed given.'
-			identifier: argument.type
-			count: 1
-			path: app/cdash/tests/test_viewdynamicanalysisfile.php
-
 		-
 			rawMessage: 'Parameter #1 $stmt of function pdo_execute expects PDOStatement, (PDOStatement|false) given.'
 			identifier: argument.type

routes/api.php

@@ -36,7 +36,6 @@
 Route::get('/v1/getSubProjectDependencies.php', 'SubProjectController@apiDependenciesGraph');
 
 Route::get('/v1/viewDynamicAnalysis.php', 'DynamicAnalysisController@apiViewDynamicAnalysis');
-Route::get('/v1/viewDynamicAnalysisFile.php', 'DynamicAnalysisController@apiViewDynamicAnalysisFile');
 
 Route::get('/v1/buildProperties.php', 'BuildPropertiesController@apiBuildProperties');