Revert Repository.php try/catch and DoneHandler.php check logic for testing

Author: arhowe00

app/Http/Submission/Handlers/DoneHandler.php

@@ -63,9 +63,10 @@ public function endElement($parser, $name): void
             $this->Build->UpdateBuild($this->Build->Id, -1, -1);
             $this->Build->MarkAsDone(true);
 
-            // Create or update the GitHub check for this commit.
-            $revision = \App\Models\Build::findOrFail((int) $this->Build->Id)->updateStep->revision ?? '';
-            if ($revision !== '') {
+            // Should we re-run any checks that were previously marked
+            // as pending?
+            if ($pendingSubmissionsModel !== null && $pendingSubmissionsModel->recheck) {
+                $revision = \App\Models\Build::findOrFail((int) $this->Build->Id)->updateStep->revision ?? '';
                 Repository::createOrUpdateCheck($revision);
             }
 

app/cdash/app/Model/Repository.php

@@ -70,11 +70,7 @@ public static function createOrUpdateCheck($sha): void
         $project = new Project();
         $project->Id = $projectid;
         $project->Fill();
-        try {
-            $repositoryInterface = self::getRepositoryInterface($project);
-        } catch (Exception $e) {
-            return;
-        }
+        $repositoryInterface = self::getRepositoryInterface($project);
         $repositoryInterface->createCheck($sha);
     }