refactor(tests): drop unrelated state-manifest timeout change and centralize SESSION_SAVE_TIMEOUT

Author: PaulHax

src/store/datasets-dicom.ts

@@ -167,11 +167,6 @@ export const useDICOMStore = defineStore('dicom', {
             if (importedAsCine) return;
           }
 
-          if (this.volumeInfo[id]?.kind === 'cine') {
-            throw new Error(
-              `Volume ${id} is already loaded as a cine clip; cannot re-import as a chunk volume.`
-            );
-          }
           const cachedImage = imageCacheStore.imageById[id];
           if (cachedImage && !(cachedImage instanceof DicomChunkImage)) {
             throw new Error(

src/store/views.ts

@@ -267,7 +267,8 @@ export const useViewStore = defineStore('view', () => {
 
     view.dataID = dataID;
     ViewDataChangeEvent.trigger(viewID, dataID);
-    // Global tools resolve their image through activeView.
+    // If activeView is null/stale, fall back to a visible view so global
+    // tools (which resolve their image through activeView) have one to read.
     ensureActiveViewIsVisible();
   }
 

tests/specs/cine-ruler-session.e2e.ts

@@ -4,7 +4,7 @@
 // silently lose the per-frame association.
 import * as path from 'path';
 import { CINE_US_DATASET } from './configTestUtils';
-import { openUrls, waitForFileExists } from './utils';
+import { openUrls, SESSION_SAVE_TIMEOUT, waitForFileExists } from './utils';
 import { volViewPage } from '../pageobjects/volview.page';
 import { TEMP_DIR } from '../../wdio.shared.conf';
 import {
@@ -16,8 +16,6 @@ import {
   waitForFrame,
 } from './cineTestUtils';
 
-const SESSION_SAVE_TIMEOUT = 40000;
-
 const placeRulerAtCanvasCenter = async () => {
   const rulerToolButton = await $('button span i[class~=mdi-ruler]');
   await rulerToolButton.click();

tests/specs/session-state-lifecycle.e2e.ts

@@ -2,12 +2,15 @@ import * as path from 'path';
 import * as fs from 'fs';
 import JSZip from 'jszip';
 import { MINIMAL_501_SESSION, PROSTATEX_DATASET } from './configTestUtils';
-import { downloadFile, openUrls, waitForFileExists } from './utils';
+import {
+  downloadFile,
+  openUrls,
+  SESSION_SAVE_TIMEOUT,
+  waitForFileExists,
+} from './utils';
 import { setValueVueInput, volViewPage } from '../pageobjects/volview.page';
 import { TEMP_DIR } from '../../wdio.shared.conf';
 
-const SESSION_SAVE_TIMEOUT = 40000;
-
 const waitForElementCount = async (selector: string, minCount = 1) => {
   await browser.waitUntil(async () => {
     const count = await browser.execute(

tests/specs/state-manifest.e2e.ts

@@ -3,9 +3,7 @@ import { FIXTURES, WINDOW_SIZE } from '../../wdio.shared.conf';
 import { volViewPage } from '../pageobjects/volview.page';
 import { openVolViewPage, writeManifestToZip } from './utils';
 
-describe('State file manifest.json code', function () {
-  this.timeout(120_000);
-
+describe('State file manifest.json code', () => {
   it('has no errors loading version 5.0.1 manifest.json file ', async () => {
     const manifestPath = path.join(
       FIXTURES,

tests/specs/utils.ts

@@ -78,6 +78,8 @@ export async function openVolViewPage(fileName: string) {
 
 type RemoteResourceType = z.infer<typeof RemoteResource> & { name: string };
 
+export const SESSION_SAVE_TIMEOUT = 40_000;
+
 export const waitForFileExists = (filePath: string, timeout: number) =>
   new Promise<void>((resolve, reject) => {
     const dir = path.dirname(filePath);