Skip to content

Commit 40ff400

Browse files
authored
Merge pull request #637 from Kitware/chip-fix
Fix label button layout and Layering
2 parents 7b721aa + 9cbc411 commit 40ff400

2 files changed

Lines changed: 14 additions & 3 deletions

File tree

src/components/EditableChipList.vue

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,8 +47,7 @@ const itemsToRender = computed(() =>
4747
@click="toggle"
4848
>
4949
<slot name="item-prepend" :key="key" :item="items[idx]"></slot>
50-
<span class="overflow-hidden">{{ title }}</span>
51-
<v-spacer />
50+
<span class="text-truncate">{{ title }}</span>
5251
<slot name="item-append" :key="key" :item="items[idx]"></slot>
5352
</v-chip>
5453
</v-item>
@@ -70,4 +69,8 @@ const itemsToRender = computed(() =>
7069
background-color: rgb(var(--v-theme-selection-bg-color));
7170
border-color: rgb(var(--v-theme-selection-border-color));
7271
}
72+
73+
.v-chip:deep() .v-chip__content {
74+
width: 100%;
75+
}
7376
</style>

src/store/datasets-layers.ts

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
1-
import { ref } from 'vue';
1+
import { computed, ref, unref } from 'vue';
2+
import { until } from '@vueuse/core';
23
import vtkImageData from '@kitware/vtk.js/Common/DataModel/ImageData';
34
import vtkBoundingBox from '@kitware/vtk.js/Common/DataModel/BoundingBox';
45
import { defineStore } from 'pinia';
@@ -7,6 +8,7 @@ import { Maybe } from '@/src/types';
78
import { ensureSameSpace } from '@/src/io/resample/resample';
89
import { useErrorMessage } from '../composables/useErrorMessage';
910
import { Manifest, StateFile } from '../io/state-file/schema';
11+
import useChunkStore from './chunks';
1012

1113
// differ from Image/Volume IDs with a branded type
1214
export type LayerID = string & { __type: 'LayerID' };
@@ -66,6 +68,12 @@ export const useLayersStore = defineStore('layer', () => {
6668
parent: DataSelection,
6769
source: DataSelection
6870
) {
71+
// ensureSameSpace need final image array to resample, so wait for all chunks
72+
const doneLoading = computed(
73+
() => !unref(useChunkStore().chunkImageById[source].isLoading)
74+
);
75+
await until(doneLoading).toBe(true);
76+
6977
return useErrorMessage('Failed to build layer', async () => {
7078
try {
7179
await this._addLayer(parent, source);

0 commit comments

Comments
 (0)