refactor(cine): tighten comments and types from simplify review

- Trim verbose comments in VtkSliceView, useAnnotationTool, useVtkView
  to non-obvious WHY only; note why public cancelAnimation is unusable.
- Rename cineActiveOnly -> restrictToActiveView so the flag describes the
  behavior, not the trigger.
- Drop speculative `as any` casts and removeListener fallback in the
  interactor-lifecycle e2e; align BrowserLogEntry with WDIO's LogEntry.

Author: PaulHax

src/components/vtk/VtkSliceView.vue

@@ -101,12 +101,10 @@ watchImmediate(
   }
 );
 
-// Restore persisted camera state before the clipping-range reset below.
-// resetCameraClippingRange uses the camera's current position to compute
-// near/far planes, so on remount (e.g. maximize toggle) it must run after
-// syncRef has written the saved position back into the camera — otherwise
-// the planes are computed against the default camera and the slice falls
-// outside the clip volume, leaving a black canvas.
+// Must run before the clipping-range watcher below: resetCameraClippingRange
+// computes near/far from the camera's current position, so on remount the
+// saved position must be syncRef'd back first or the slice falls outside
+// the clip volume and the canvas goes black.
 usePersistCameraConfig(viewID, imageID, view.renderer.getActiveCamera());
 
 watchImmediate([imageMetadata, disableCameraAutoReset], () => {

src/core/vtk/useVtkView.ts

@@ -19,15 +19,16 @@ import {
   watchPostEffect,
 } from 'vue';
 
-type VtkInteractorAnimationModel = {
-  animationRequest?: number | null;
-};
-
+// vtk.js' public interactor.cancelAnimation() is a no-op while the
+// post-wheel extension window is still open (model._animationExtendedEnd),
+// so on dispose during that window a pending rAF survives and fires against
+// the deleted interactor. Reach into the private animationRequest field to
+// cancel it directly.
 function cancelPendingInteractorAnimationFrame(
   interactor: vtkRenderWindowInteractor
 ) {
   const model = (
-    interactor as unknown as { get(): VtkInteractorAnimationModel }
+    interactor as unknown as { get(): { animationRequest?: number | null } }
   ).get();
   if (model.animationRequest == null) return;
 

src/store/tools/useAnnotationTool.ts

@@ -147,15 +147,15 @@ export const useAnnotationTool = <
     if (!toolImageFrame) return;
 
     const viewStore = useViewStore();
-    // Cine forces every 2D view's effective axis to Axial, so without this
-    // every cine view would jump to the same frame; scope it to the active
-    // view instead.
-    const cineActiveOnly = isCineImage(imageID);
+    // Cine collapses every 2D view to Axial, so without the active-view gate
+    // every cine view would jump to the same frame.
+    const restrictToActiveView = isCineImage(imageID);
     const relevantViews = viewStore.getAllViews().filter((view) => {
       if (view.type !== '2D') return false;
       if (getEffectiveViewAxis(view, imageID) !== toolImageFrame.axis)
         return false;
-      if (cineActiveOnly && view.id !== viewStore.activeView) return false;
+      if (restrictToActiveView && view.id !== viewStore.activeView)
+        return false;
       return true;
     });
 

tests/specs/vtk-interactor-lifecycle.e2e.ts

@@ -4,15 +4,7 @@ import { openUrls } from './utils';
 const VIEW_SELECTOR = 'div[data-testid="vtk-view vtk-two-view"]';
 const DELETED_INSTANCE_ERROR = 'instance deleted - cannot call any method';
 
-type BrowserLogEntry = {
-  level?: string;
-  text?: string;
-  message?: string;
-};
-
-function formatBrowserLogEntry(entry: BrowserLogEntry) {
-  return entry.text ?? entry.message ?? JSON.stringify(entry);
-}
+type BrowserLogEntry = { text: string | null };
 
 async function captureBrowserConsoleLogsDuring(action: () => Promise<void>) {
   const logs: BrowserLogEntry[] = [];
@@ -21,14 +13,13 @@ async function captureBrowserConsoleLogsDuring(action: () => Promise<void>) {
   };
 
   await (browser as any).sessionSubscribe({ events: ['log.entryAdded'] });
-  (browser as any).on('log.entryAdded', handler);
+  browser.on('log.entryAdded', handler);
 
   try {
     await action();
     await browser.pause(250);
   } finally {
-    (browser as any).off?.('log.entryAdded', handler);
-    (browser as any).removeListener?.('log.entryAdded', handler);
+    browser.off('log.entryAdded', handler);
   }
 
   return logs;
@@ -84,7 +75,7 @@ describe('VTK interactor lifecycle', () => {
     });
 
     const deletedInteractorErrors = logs
-      .map(formatBrowserLogEntry)
+      .map((entry) => entry.text ?? '')
       .filter((message) => message.includes(DELETED_INSTANCE_ERROR));
 
     expect(deletedInteractorErrors).toEqual([]);