fix(tools): ignore non-annotation widget selections

Author: PaulHax

.github/workflows/e2e.yml

@@ -11,7 +11,7 @@ jobs:
     name: E2E Testing on ${{ matrix.os }}
     runs-on: ${{ matrix.os }}
     env:
-      DOWNLOAD_TIMEOUT: 60000
+      DOWNLOAD_TIMEOUT: 90000
       VITE_SHOW_SAMPLE_DATA: true
     steps:
       - uses: actions/checkout@v4

src/components/ProcessTypeSelector.vue

@@ -7,14 +7,14 @@
             v-bind="props"
             variant="tonal"
             block
+            spaced="end"
             class="process-type-menu-button"
             data-testid="process-type-selector"
+            :prepend-icon="activeDefinition.icon"
+            append-icon="mdi-menu-down"
             :disabled="isDisabled"
           >
-            <v-icon start>{{ activeDefinition.icon }}</v-icon>
-            <span>{{ activeDefinition.label }}</span>
-            <v-spacer />
-            <v-icon end>mdi-menu-down</v-icon>
+            <span class="process-type-label">{{ activeDefinition.label }}</span>
           </v-btn>
         </template>
 
@@ -68,4 +68,9 @@ const activeDefinition = computed(
   justify-content: start;
   min-height: 40px;
 }
+
+.process-type-label {
+  overflow: hidden;
+  text-overflow: ellipsis;
+}
 </style>

src/components/tools/SelectTool.vue

@@ -4,7 +4,10 @@ import { WIDGET_PRIORITY } from '@kitware/vtk.js/Widgets/Core/AbstractWidget/Con
 import { useToolSelectionStore } from '@/src/store/tools/toolSelection';
 import { useToolStore } from '@/src/store/tools';
 import { Tools } from '@/src/store/tools/types';
-import { vtkAnnotationToolWidget } from '@/src/vtk/ToolWidgetUtils/types';
+import type {
+  vtkAnnotationToolWidget,
+  vtkAnnotationWidgetState,
+} from '@/src/vtk/ToolWidgetUtils/types';
 import { inject } from 'vue';
 import { VtkViewContext } from '@/src/components/vtk/context';
 
@@ -16,6 +19,17 @@ const toolStore = useToolStore();
 
 const PLACING_TOOLS = [Tools.Ruler, Tools.Rectangle, Tools.Polygon];
 
+const isAnnotationWidgetState = (
+  widgetState: unknown
+): widgetState is vtkAnnotationWidgetState => {
+  const candidate = widgetState as Partial<vtkAnnotationWidgetState> | null;
+  return (
+    !!candidate &&
+    typeof candidate.getId === 'function' &&
+    typeof candidate.getToolType === 'function'
+  );
+};
+
 onVTKEvent(
   view.interactor,
   'onLeftButtonPress',
@@ -28,9 +42,16 @@ onVTKEvent(
     const withModifiers = !!(event.shiftKey || event.controlKey);
     const selectedData = view.widgetManager.getSelectedData();
     if ('widget' in selectedData) {
-      // clicked in empty space.
-      const widget = selectedData.widget as vtkAnnotationToolWidget;
-      const widgetState = widget.getWidgetState();
+      const widget =
+        selectedData.widget as Partial<vtkAnnotationToolWidget> | null;
+      const widgetState = widget?.getWidgetState?.();
+      if (!isAnnotationWidgetState(widgetState)) {
+        if (!withModifiers) {
+          selectionStore.clearSelection();
+        }
+        return;
+      }
+
       const id = widgetState.getId();
       const type = widgetState.getToolType();
       // preserve if we've used shift or ctrl