refactor(gaussianSmooth): simplfy process interface

Author: PaulHax

src/components/ProcessControls.vue

@@ -16,11 +16,7 @@
 
 <script setup lang="ts">
 import { computed } from 'vue';
-import {
-  ProcessType,
-  useProcessStore,
-  type ProcessAlgorithm,
-} from '../store/tools/process';
+import { ProcessType, useProcessStore } from '../store/tools/process';
 import ProcessTypeSelector from './ProcessTypeSelector.vue';
 import ProcessWorkflow from './ProcessWorkflow.vue';
 import FillBetweenParameterControls from './FillBetweenParameterControls.vue';
@@ -34,16 +30,6 @@ const gaussianSmoothStore = useGaussianSmoothStore();
 
 const activeProcessType = computed(() => processStore.activeProcessType);
 
-// Create algorithm adapters for the ProcessWorkflow component
-const fillBetweenAlgorithm: ProcessAlgorithm = {
-  compute: async (segImage, activeSegment) => {
-    return fillBetweenStore.computeAlgorithm(segImage, activeSegment);
-  },
-};
-
-const gaussianSmoothAlgorithm: ProcessAlgorithm = {
-  compute: async (segImage, activeSegment) => {
-    return gaussianSmoothStore.computeAlgorithm(segImage, activeSegment);
-  },
-};
+const fillBetweenAlgorithm = fillBetweenStore.computeAlgorithm;
+const gaussianSmoothAlgorithm = gaussianSmoothStore.computeAlgorithm;
 </script>

src/components/ProcessWorkflow.vue

@@ -78,10 +78,8 @@ function handleToggleChange(value: number | string) {
 
 function handleConfirm() {
   if (showingOriginal.value) {
-    // User is viewing original - cancel the process
     processStore.cancelProcess();
   } else {
-    // User is viewing processed - confirm the process
     processStore.confirmProcess();
   }
 }

src/core/tools/paint/gaussianSmooth.worker.ts

@@ -1,5 +1,6 @@
 import * as Comlink from 'comlink';
 import { TypedArray } from '@kitware/vtk.js/types';
+import { createTypedArrayLike } from '@/src/utils';
 
 export interface GaussianSmoothParams {
   sigma: number;
@@ -129,13 +130,12 @@ function gaussianFilter3D(
   const kernelX = generateGaussianKernel(sigmaPixels[0], radiusFactor);
   const kernelY = generateGaussianKernel(sigmaPixels[1], radiusFactor);
   const kernelZ = generateGaussianKernel(sigmaPixels[2], radiusFactor);
-  const temp1 = new Float32Array(totalSize);
-  const temp2 = new Float32Array(totalSize);
+  const temp = new Float32Array(totalSize);
   const output = new Float32Array(totalSize);
 
-  convolve1D(inputData, temp1, dimensions, kernelX, 0);
-  convolve1D(temp1, temp2, dimensions, kernelY, 1);
-  convolve1D(temp2, output, dimensions, kernelZ, 2);
+  convolve1D(inputData, output, dimensions, kernelX, 0);
+  convolve1D(output, temp, dimensions, kernelY, 1);
+  convolve1D(temp, output, dimensions, kernelZ, 2);
 
   return output;
 }
@@ -237,7 +237,7 @@ function copySubVolumeBack(
 
         if (origLabel === label || origLabel === 0) {
           // eslint-disable-next-line no-param-reassign
-          (originalData as any)[origIndex] = subValue > 127.5 ? label : 0;
+          originalData[origIndex] = subValue > 127.5 ? label : 0;
         }
         subIndex++;
       }
@@ -274,9 +274,7 @@ export function gaussianSmoothLabelMapWorker(input: {
   }
 
   if (originalLabelCount === 0) {
-    const outputData = new (originalData.constructor as any)(
-      originalData.length
-    );
+    const outputData = createTypedArrayLike(originalData, originalData.length);
     for (let i = 0; i < originalData.length; i++) {
       outputData[i] = originalData[i];
     }
@@ -291,9 +289,7 @@ export function gaussianSmoothLabelMapWorker(input: {
 
   const bounds = calculateBoundingBox(originalData, dimensions, label);
   if (!bounds) {
-    const outputData = new (originalData.constructor as any)(
-      originalData.length
-    );
+    const outputData = createTypedArrayLike(originalData, originalData.length);
     for (let i = 0; i < originalData.length; i++) {
       outputData[i] = originalData[i];
     }
@@ -320,7 +316,7 @@ export function gaussianSmoothLabelMapWorker(input: {
     1.5
   );
 
-  const outputData = new (originalData.constructor as any)(originalData.length);
+  const outputData = createTypedArrayLike(originalData, originalData.length);
   for (let i = 0; i < originalData.length; i++) {
     outputData[i] = originalData[i];
   }

src/store/tools/gaussianSmooth.ts

@@ -1,6 +1,5 @@
 import { defineStore } from 'pinia';
 import { ref } from 'vue';
-import { TypedArray } from '@kitware/vtk.js/types';
 import * as Comlink from 'comlink';
 import vtkLabelMap from '@/src/vtk/LabelMap';
 import { gaussianSmoothLabelMapWorker } from '@/src/core/tools/paint/gaussianSmooth.worker';
@@ -62,7 +61,7 @@ export const useGaussianSmoothStore = defineStore('gaussianSmooth', () => {
   async function computeAlgorithm(
     segImage: vtkLabelMap,
     activeSegment: number
-  ): Promise<TypedArray> {
+  ) {
     const params = {
       sigma: sigma.value,
       label: activeSegment,

src/store/tools/process.ts

@@ -36,12 +36,10 @@ type PreviewingState = {
 
 type ProcessState = StartState | ComputingState | PreviewingState;
 
-export interface ProcessAlgorithm {
-  compute: (
-    segImage: vtkLabelMap,
-    activeSegment: number
-  ) => Promise<TypedArray>;
-}
+export type ProcessAlgorithm = (
+  segImage: vtkLabelMap,
+  activeSegment: number
+) => Promise<TypedArray | number[]>;
 
 export const useProcessStore = defineStore('process', () => {
   const processState = ref<ProcessState>({ step: 'start' });
@@ -117,10 +115,7 @@ export const useProcessStore = defineStore('process', () => {
     }
 
     try {
-      const outputScalars = await algorithm.compute(
-        segImage,
-        paintStore.activeSegment
-      );
+      const outputScalars = await algorithm(segImage, paintStore.activeSegment);
 
       // If the state changed during the async operation, stop processing
       if (processState.value.step !== 'computing') {

src/utils/index.ts

@@ -258,6 +258,23 @@ export const TypedArrayConstructorNames = [
   'Float64Array',
 ];
 
+/**
+ * Creates a new typed array of the same type as the source array.
+ * This utility handles the TypeScript typing issues when using array.constructor.
+ *
+ * @param sourceArray The source array to match the type of
+ * @param arrayLength The length of the new array
+ * @returns A new array of the same type as sourceArray
+ */
+export function createTypedArrayLike<T extends TypedArray | number[]>(
+  sourceArray: T,
+  arrayLength: number
+): T {
+  return new (sourceArray.constructor as new (length: number) => T)(
+    arrayLength
+  );
+}
+
 // https://stackoverflow.com/a/74823834
 type Entries<T> = {
   [K in keyof T]-?: [K, T[K]];