Skip to content

fix(ParentedView): mark wheel event listener as passive#150

Merged
sankhesh merged 1 commit into
Kitware:masterfrom
danyim:fix/passive-wheel-event-listener
May 22, 2026
Merged

fix(ParentedView): mark wheel event listener as passive#150
sankhesh merged 1 commit into
Kitware:masterfrom
danyim:fix/passive-wheel-event-listener

Conversation

@danyim
Copy link
Copy Markdown
Contributor

@danyim danyim commented May 21, 2026

Problem

The wheel event listener in ParentedView is registered with { capture: true } but without passive: true. This triggers a browser violation warning:

[Violation] Added non-passive event listener to a scroll-blocking 'wheel' event. Consider marking event handler as 'passive' to make the page more responsive.

Fix

Add passive: true to the wheel event listener options:

useEventListener(
  containerRef,
  'wheel',
  () => { switchTarget(); },
  { capture: true, passive: true }  // was: { capture: true }
);

The handler only calls switchTarget() and never calls preventDefault(), so marking it passive is safe and removes the browser warning.

The wheel event listener on the viewport container was registered with
{ capture: true } but without passive: true, triggering a browser
violation warning about scroll-blocking event handlers.

The handler only calls switchTarget() and never calls preventDefault(),
so marking it passive is safe and removes the warning.
@sankhesh sankhesh merged commit 6a3c16c into Kitware:master May 22, 2026
1 check passed
@github-actions
Copy link
Copy Markdown

🎉 This PR is included in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants