refactor: move method definitions into vtk.js convention function bodies

Address review feedback: move registerOverride from extend() into
the main function body for both ViewNodeFactory and SharedRenderWindow.

Author: PaulHax

Sources/Rendering/OpenGL/SharedRenderWindow/index.js

@@ -100,6 +100,11 @@ function resetGLState(gl, shaderCache) {
 
 function vtkSharedRenderWindow(publicAPI, model) {
   model.classHierarchy.push('vtkSharedRenderWindow');
+
+  publicAPI
+    .getViewNodeFactory()
+    .registerOverride('vtkRenderer', vtkSharedRenderer.newInstance);
+
   let renderEventSubscription = null;
   let renderCallback = null;
   let suppressRenderEvent = false;
@@ -237,9 +242,6 @@ export function extend(publicAPI, model, initialValues = {}) {
     'autoClearDepth',
   ]);
   vtkSharedRenderWindow(publicAPI, model);
-  publicAPI
-    .getViewNodeFactory()
-    .registerOverride('vtkRenderer', vtkSharedRenderer.newInstance);
 }
 
 export const newInstance = macro.newInstance(extend, 'vtkSharedRenderWindow');

Sources/Rendering/OpenGL/ViewNodeFactory/index.js

@@ -14,6 +14,10 @@ export function registerOverride(className, fn) {
 function vtkOpenGLViewNodeFactory(publicAPI, model) {
   // Set our className
   model.classHierarchy.push('vtkOpenGLViewNodeFactory');
+
+  publicAPI.registerOverride = (className, fn) => {
+    model.overrides[className] = fn;
+  };
 }
 
 // ----------------------------------------------------------------------------
@@ -34,10 +38,6 @@ export function extend(publicAPI, model, initialValues = {}) {
   // Inheritance
   vtkViewNodeFactory.extend(publicAPI, model, initialValues);
 
-  publicAPI.registerOverride = (className, fn) => {
-    model.overrides[className] = fn;
-  };
-
   // Object methods
   vtkOpenGLViewNodeFactory(publicAPI, model);
 }