refactor(WebGL): remove support for WebGL1

Author: daker

Sources/Rendering/OpenGL/CellArrayBufferObject/index.js

@@ -253,6 +253,9 @@ function vtkConvolution2DPass(publicAPI, model) {
       points,
       tcoords,
       cellOffset: 0,
+      // This pass draws with gl.drawArrays, so it needs the flattened
+      // (non indexed) vertex layout where elementCount matches the vertices.
+      forceFlatten: true,
     });
 
     model.VBOBuildTime.modified();

Sources/Rendering/OpenGL/Convolution2DPass/index.js

@@ -38,7 +38,7 @@ function vtkFramebuffer(publicAPI, model) {
   };
 
   publicAPI.saveCurrentBuffers = (modeIn) => {
-    // noop on webgl 1
+    // noop on webgl
   };
 
   publicAPI.restorePreviousBindingsAndBuffers = (modeIn) => {
@@ -64,7 +64,7 @@ function vtkFramebuffer(publicAPI, model) {
   };
 
   publicAPI.restorePreviousBuffers = (modeIn) => {
-    // currently a noop on webgl1
+    // currently a noop
   };
 
   publicAPI.bind = (modeArg = null) => {
@@ -104,14 +104,7 @@ function vtkFramebuffer(publicAPI, model) {
 
     let glAttachment = gl.COLOR_ATTACHMENT0;
     if (attachment > 0) {
-      if (model._openGLRenderWindow.getWebgl2()) {
-        glAttachment += attachment;
-      } else {
-        macro.vtkErrorMacro(
-          'Using multiple framebuffer attachments requires WebGL 2'
-        );
-        return;
-      }
+      glAttachment += attachment;
     }
     model.colorBuffers[attachment] = texture;
     gl.framebufferTexture2D(
@@ -135,14 +128,7 @@ function vtkFramebuffer(publicAPI, model) {
 
     let glAttachment = gl.COLOR_ATTACHMENT0;
     if (attachment > 0) {
-      if (model._openGLRenderWindow.getWebgl2()) {
-        glAttachment += attachment;
-      } else {
-        macro.vtkErrorMacro(
-          'Using multiple framebuffer attachments requires WebGL 2'
-        );
-        return;
-      }
+      glAttachment += attachment;
     }
 
     gl.framebufferTexture2D(
@@ -164,20 +150,14 @@ function vtkFramebuffer(publicAPI, model) {
       return;
     }
 
-    if (model._openGLRenderWindow.getWebgl2()) {
-      const gl = model.context;
-      gl.framebufferTexture2D(
-        gl.FRAMEBUFFER,
-        gl.DEPTH_ATTACHMENT,
-        gl.TEXTURE_2D,
-        texture.getHandle(),
-        0
-      );
-    } else {
-      macro.vtkErrorMacro(
-        'Attaching depth buffer textures to fbo requires WebGL 2'
-      );
-    }
+    const gl = model.context;
+    gl.framebufferTexture2D(
+      gl.FRAMEBUFFER,
+      gl.DEPTH_ATTACHMENT,
+      gl.TEXTURE_2D,
+      texture.getHandle(),
+      0
+    );
   };
 
   publicAPI.removeDepthBuffer = () => {
@@ -188,20 +168,14 @@ function vtkFramebuffer(publicAPI, model) {
       return;
     }
 
-    if (model._openGLRenderWindow.getWebgl2()) {
-      const gl = model.context;
-      gl.framebufferTexture2D(
-        gl.FRAMEBUFFER,
-        gl.DEPTH_ATTACHMENT,
-        gl.TEXTURE_2D,
-        null,
-        0
-      );
-    } else {
-      macro.vtkErrorMacro(
-        'Attaching depth buffer textures to framebuffers requires WebGL 2'
-      );
-    }
+    const gl = model.context;
+    gl.framebufferTexture2D(
+      gl.FRAMEBUFFER,
+      gl.DEPTH_ATTACHMENT,
+      gl.TEXTURE_2D,
+      null,
+      0
+    );
   };
 
   publicAPI.getGLFramebuffer = () => model.glFramebuffer;