Skip to content

BREAKING CHANGE: feat(macros)!: remove getStateArrayMapFunc #3489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
PaulHax wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −16
Open

BREAKING CHANGE: feat(macros)!: remove getStateArrayMapFunc #3489

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions BREAKING_CHANGES.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,8 @@
## From 35.x to 36

- **macros**: `getStateArrayMapFunc` has been removed. Inline the equivalent where needed, e.g. `arr.map((item) => (item && item.isA ? item.getState() : item))`.


## From 34.x to 35

- **vtkMapper**: mappers should overwrite `computeBounds()` instead of `getBounds` that now calls `computeBounds()` before returning a copy of the mapper bounds.
Expand Down
8 changes: 0 additions & 8 deletions Sources/macros.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,13 +140,6 @@ declare function safeArrays(model: object): void;
*/
declare function enumToString(e: object, value: any): string;

/**
* If item is a VtkObject, return its getState() otherwise return itself.
*
* @param item object to extract its state from
*/
declare function getStateArrayMapFunc(item: any): any;

/**
* Call provided function on the next EDT pass
*
Expand Down Expand Up @@ -725,7 +718,6 @@ declare const Macro: {
get: typeof get;
getArray: typeof getArray;
getCurrentGlobalMTime(): Number;
getStateArrayMapFunc: typeof getStateArrayMapFunc;
isVtkObject: typeof isVtkObject;
keystore: typeof keystore;
measurePromiseExecution: typeof measurePromiseExecution;
Expand Down
8 changes: 0 additions & 8 deletions Sources/macros.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,6 @@ function enumToString(e, value) {
return Object.keys(e).find((key) => e[key] === value);
}

function getStateArrayMapFunc(item) {
if (item && item.isA) {
return item.getState();
}
return item;
}

// ----------------------------------------------------------------------------
// setImmediate
// ----------------------------------------------------------------------------
Expand Down Expand Up @@ -1797,7 +1790,6 @@ export default {
get,
getArray,
getCurrentGlobalMTime,
getStateArrayMapFunc,
isVtkObject,
keystore,
measurePromiseExecution,
Expand Down
Loading