Fix modeltransform#3538
Open
sankhesh wants to merge 4 commits into
Open
Conversation
The model transform matrix was being post-multiplied causing the transform to be applied in in camera space rather than world space. This change fixes making the transform orientation-invariant regardless of camera rotation.
finetjul
reviewed
Jun 26, 2026
finetjul
left a comment
finetjul
left a comment
Member
There was a problem hiding this comment.
Why setModelTransformMatrix and getModelTransformMatrix are not generated with macro.setGet ?
sankhesh
force-pushed
the
fix-modeltransform
branch
from
1a92c52 to
0e9ff2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
When applying the model transform matrix, it was observed that the matrix was being applied in the view space leading to unintended orientation specific artifacts. This change fixes the order of matrix multiplication for the transform and adds testing to ensure that the transform is applied camera-orientation-agnostically in the world space.
Results
Changes
PR and Code Checklist
npm run reformatto have correctly formatted codeTesting