Skip to content

Commit 85e8618

Browse files
AlexyPellegriniAlexyPellegrini
committed
fix: address commitlint issues
1 parent 72a2125 commit 85e8618

File tree

17 files changed

+65
-68
lines changed

17 files changed

+65
-68
lines changed

‎.github/workflows/build-wheels.yml‎

Lines changed: 33 additions & 34 deletions
Original file line numberDiff line numberDiff line change
@@ -1,31 +1,31 @@
11
name: build-wheels
2-
description: Build Slicer LayerDM and Slicer LayerDM SDK for given platform
32

43
on:
54
workflow_call:
65
inputs:
76
os:
8-
description: 'OS to run on, must be one of supported runner type'
7+
description: "OS to run on, must be one of supported runner type"
98
required: true
109
type: string
1110
build-target:
12-
description: 'CIBW build target (e.g., cp310-manylinux_x86_64)'
11+
description: "CIBW build target (e.g., cp310-manylinux_x86_64)"
1312
required: true
1413
type: string
1514
python-version:
16-
description: 'CIBW build target (e.g., 3.10)'
15+
description: "CIBW build target (e.g., 3.10)"
1716
required: true
1817
type: string
1918
platform-tag:
20-
description: 'Wheel platform tag to apply after building.'
19+
description: "Wheel platform tag to apply after building."
2120
required: true
2221
type: string
2322

2423
jobs:
2524
build-test:
2625
runs-on: ${{ inputs.os }}
27-
26+
2827
env:
28+
PIP_EXTRA_INDEX_URL: "https://vtk.org/files/wheel-sdks"
2929
CIBW_BUILD: ${{ inputs.build-target }}
3030
# Install a compiler cache on each platform
3131
CIBW_BEFORE_ALL_LINUX: "yum install -y mesa-libGL-devel glx-utils freeglut-devel"
@@ -38,35 +38,34 @@ jobs:
3838
cp $(dirname {wheel})/slicer_core*.whl {dest_dir}"
3939

4040
steps:
41-
# Build and test wheels
42-
- uses: actions/checkout@v4
41+
# Build and test wheels
42+
- uses: actions/checkout@v4
4343

44-
# This python is used to patch the project, not to build!
45-
- name: Set up Python
46-
uses: actions/setup-python@v5
47-
with:
48-
python-version: ${{ inputs.python-version }}
44+
# This python is used to patch the project, not to build!
45+
- name: Set up Python
46+
uses: actions/setup-python@v5
47+
with:
48+
python-version: ${{ inputs.python-version }}
4949

50-
- name: Build wheel
51-
uses: pypa/cibuildwheel@v3.3.1
52-
env:
53-
CIBW_TEST_COMMAND: "python -m pytest {project}/LayerDM -m runtime --verbose"
54-
with:
55-
package-dir: LayerDM
56-
output-dir: wheelhouse
50+
- name: Build wheel
51+
uses: pypa/cibuildwheel@v3.3.1
52+
env:
53+
CIBW_TEST_COMMAND: "python -m pytest {project}/LayerDM -m runtime --verbose"
54+
with:
55+
package-dir: LayerDM
56+
output-dir: wheelhouse
5757

58-
- name: Build wheel SDK
59-
uses: pypa/cibuildwheel@v3.3.1
60-
env:
61-
CIBW_TEST_COMMAND: "python -m pytest {project}/LayerDM -m sdk --verbose"
62-
with:
63-
package-dir: LayerDMSDK
64-
output-dir: wheelhouse
58+
- name: Build wheel SDK
59+
uses: pypa/cibuildwheel@v3.3.1
60+
env:
61+
CIBW_TEST_COMMAND: "python -m pytest {project}/LayerDM -m sdk --verbose"
62+
with:
63+
package-dir: LayerDMSDK
64+
output-dir: wheelhouse
6565

66-
- name: Upload wheels
67-
uses: actions/upload-artifact@v4
68-
with:
69-
name: slicer_layer_md-${{ inputs.build-target }}
70-
path:
71-
wheelhouse/slicer_layer_md-*.whl
72-
wheelhouse/slicer_layer_md_sdk-*.whl
66+
- name: Upload wheels
67+
uses: actions/upload-artifact@v4
68+
with:
69+
name: slicer_layer_md-${{ inputs.build-target }}
70+
path: wheelhouse/slicer_layer_md-*.whl
71+
wheelhouse/slicer_layer_md_sdk-*.whl

‎.github/workflows/ci.yml‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -2,20 +2,20 @@ name: CI Slicer Core
22

33
on:
44
pull_request:
5-
branches: [ main ]
5+
branches: [main]
66

77
jobs:
88
build-test:
99
strategy:
1010
fail-fast: true
1111
matrix:
1212
os: [ubuntu-latest, windows-latest, macos-15]
13-
vtk-tag: ['9.6.0']
14-
py-abi: ['cp310']
13+
vtk-tag: ["9.6.0"]
14+
py-abi: ["cp310"]
1515
include:
1616
# Python version to install on host
1717
- py-abi: cp310
18-
python-version: '3.10'
18+
python-version: "3.10"
1919
# OS name to ciwheelbuild platform name
2020
- os: ubuntu-latest
2121
platform-tag: manylinux_2_28_x86_64

‎.github/workflows/commit-lint.yml‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,4 +10,4 @@ jobs:
1010
runs-on: ubuntu-latest
1111
steps:
1212
- uses: actions/checkout@v4
13-
- uses: wagoid/commitlint-github-action@v6
13+
- uses: wagoid/commitlint-github-action@v6

‎.github/workflows/release.yml‎

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -32,17 +32,17 @@ jobs:
3232
fail-fast: true
3333
matrix:
3434
os: [ubuntu-latest, windows-latest, macos-15]
35-
py-abi: ['cp310', 'cp311', 'cp312', 'cp313']
35+
py-abi: ["cp310", "cp311", "cp312", "cp313"]
3636
include:
3737
# Python version to install on host
3838
- py-abi: cp310
39-
python-version: '3.10'
39+
python-version: "3.10"
4040
- py-abi: cp311
41-
python-version: '3.11'
41+
python-version: "3.11"
4242
- py-abi: cp312
43-
python-version: '3.12'
43+
python-version: "3.12"
4444
- py-abi: cp313
45-
python-version: '3.13'
45+
python-version: "3.13"
4646
# OS name to ciwheelbuild platform name
4747
- os: ubuntu-latest
4848
platform-tag: manylinux_2_28_x86_64
@@ -89,7 +89,7 @@ jobs:
8989
- name: Publish package distributions to PyPI
9090
uses: pypa/gh-action-pypi-publish@release/v1
9191
with:
92-
packages-dir: ./wheelhouse
92+
packages-dir: ./wheelhouse
9393

9494
upload-pypi-sdk:
9595
name: Push SDK wheel on PyPi
@@ -120,4 +120,4 @@ jobs:
120120
- name: Publish package distributions to PyPI
121121
uses: pypa/gh-action-pypi-publish@release/v1
122122
with:
123-
packages-dir: ./wheelhouse
123+
packages-dir: ./wheelhouse

‎.gitignore‎

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,5 +4,6 @@
44
/Docs/api/
55
/Docs/doxygen/
66
/node_modules/
7+
78
venv/
8-
*.whl
9+
*.whl

‎LayerDM/CMakeLists.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,4 +59,4 @@ slicerMacroBuildLoadableModule(
5959
#-----------------------------------------------------------------------------
6060
if (BUILD_TESTING)
6161
add_subdirectory(Testing)
62-
endif ()
62+
endif ()

‎LayerDM/Logic/extension.cmake‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,4 +36,4 @@ target_include_directories(
3636
${${KIT}_SOURCE_DIR}
3737
${${KIT}_BINARY_DIR}
3838
${Slicer_Base_INCLUDE_DIRS}
39-
)
39+
)

‎LayerDM/MRML/extension.cmake‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -50,4 +50,4 @@ target_include_directories(
5050
${${KIT}_BINARY_DIR}
5151
${MRMLCore_INCLUDE_DIRS}
5252
${MRMLLogic_INCLUDE_DIRS}
53-
)
53+
)

‎LayerDM/MRMLDM/extension.cmake‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,4 +82,4 @@ if(${KIT}_AUTOINIT)
8282
)
8383
endif()
8484

85-
target_compile_features(${KIT} PUBLIC cxx_std_17)
85+
target_compile_features(${KIT} PUBLIC cxx_std_17)

‎LayerDM/tests/packages/build_module/MRMLDM/vtk.module‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ IMPLEMENTABLE
66
DEPENDS
77
SlicerLayerDM::MRMLDisplayableManager
88
DESCRIPTION
9-
"vtkDummyMRMLDisplayableManager"
9+
"vtkDummyMRMLDisplayableManager"

0 commit comments

Comments
 (0)