FIX: Fix SelectionObserver crash when active node ID is unset and accessed

Thibault-Pelletier · Thibault-Pelletier · commit 9c3349c9eac6 · 2026-02-18T10:45:33.000+01:00
diff --git a/LayerDM/MRML/vtkMRMLLayerDMSelectionObserver.cxx b/LayerDM/MRML/vtkMRMLLayerDMSelectionObserver.cxx
@@ -122,7 +122,7 @@ void vtkMRMLLayerDMSelectionObserver::StopPlace() const
 
 std::string vtkMRMLLayerDMSelectionObserver::GetActivePlaceNodeID() const
 {
-  if (!this->m_selectionNode)
+  if (!this->m_selectionNode || !this->m_selectionNode->GetActivePlaceNodeID())
   {
     return "";
   }
diff --git a/LayerDM/Testing/Cxx/CMakeLists.txt b/LayerDM/Testing/Cxx/CMakeLists.txt
@@ -35,6 +35,7 @@ endforeach()
 target_link_libraries(
   ${KIT}CxxTests
   ${MODULE_TARGET_LIBRARIES}
+  vtkSlicerMarkupsModuleMRML
 )
 
 include(SlicerMacroSimpleTest)

Original file line number	Diff line number	Diff line change
`@@ -122,7 +122,7 @@ void vtkMRMLLayerDMSelectionObserver::StopPlace() const`
`122`	`122`
`123`	`123`	`std::string vtkMRMLLayerDMSelectionObserver::GetActivePlaceNodeID() const`
`124`	`124`	`{`
`125`		`- if (!this->m_selectionNode)`
	`125`	`+ if (!this->m_selectionNode \|\| !this->m_selectionNode->GetActivePlaceNodeID())`
`126`	`126`	`{`
`127`	`127`	`return "";`
`128`	`128`	`}`
Original file line number	Diff line number	Diff line change
`@@ -35,6 +35,7 @@ endforeach()`
`35`	`35`	`target_link_libraries(`
`36`	`36`	`${KIT}CxxTests`
`37`	`37`	`${MODULE_TARGET_LIBRARIES}`
	`38`	`+ vtkSlicerMarkupsModuleMRML`
`38`	`39`	`)`
`39`	`40`
`40`	`41`	`include(SlicerMacroSimpleTest)`