Skip to content

Commit 4e12b46

Browse files
committed
COMP: Fix -Winconsistent-missing-override
1 parent 8a348d3 commit 4e12b46

File tree

6 files changed

+24
-24
lines changed

6 files changed

+24
-24
lines changed

VirtualReality/Logic/vtkSlicerVirtualRealityLogic.h

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ class VTK_SLICER_VIRTUALREALITY_MODULE_LOGIC_EXPORT vtkSlicerVirtualRealityLogic
4343
public:
4444
static vtkSlicerVirtualRealityLogic* New();
4545
vtkTypeMacro(vtkSlicerVirtualRealityLogic, vtkSlicerModuleLogic);
46-
void PrintSelf(ostream& os, vtkIndent indent);
46+
void PrintSelf(ostream& os, vtkIndent indent) override;
4747

4848
/// Creates a singleton virtual reality view node and adds it to the scene.
4949
/// If there is a virtual reality view node in the scene already then it just returns that.
@@ -90,14 +90,14 @@ class VTK_SLICER_VIRTUALREALITY_MODULE_LOGIC_EXPORT vtkSlicerVirtualRealityLogic
9090

9191
void SetActiveViewNode(vtkMRMLVirtualRealityViewNode* vrViewNode);
9292

93-
virtual void SetMRMLSceneInternal(vtkMRMLScene* newScene);
93+
void SetMRMLSceneInternal(vtkMRMLScene* newScene) override;
9494
/// Register MRML Node classes to Scene. Gets called automatically when the MRMLScene is attached to this logic class.
95-
virtual void RegisterNodes();
96-
virtual void UpdateFromMRMLScene();
97-
virtual void OnMRMLSceneNodeAdded(vtkMRMLNode* node);
98-
virtual void OnMRMLSceneNodeRemoved(vtkMRMLNode* node);
99-
virtual void OnMRMLSceneEndImport();
100-
virtual void ProcessMRMLNodesEvents(vtkObject* caller, unsigned long event, void* callData);
95+
void RegisterNodes() override;
96+
void UpdateFromMRMLScene() override;
97+
void OnMRMLSceneNodeAdded(vtkMRMLNode* node) override;
98+
void OnMRMLSceneNodeRemoved(vtkMRMLNode* node) override;
99+
void OnMRMLSceneEndImport() override;
100+
void ProcessMRMLNodesEvents(vtkObject* caller, unsigned long event, void* callData) override;
101101

102102
protected:
103103
/// Active VR view node

VirtualReality/MRML/vtkMRMLVirtualRealityViewNode.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ class VTK_SLICER_VIRTUALREALITY_MODULE_MRML_EXPORT vtkMRMLVirtualRealityViewNode
5656
virtual const char* GetNodeTagName() override;
5757

5858
/// Update the references of the node to the scene.
59-
virtual void SetSceneReferences();
59+
void SetSceneReferences() override;
6060

6161
/// Return the color the view nodes have for the background by default.
6262
static double* defaultBackgroundColor();

VirtualReality/MRML/vtkVirtualRealityViewInteractor.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -38,9 +38,9 @@ class VTK_SLICER_VIRTUALREALITY_MODULE_MRML_EXPORT vtkVirtualRealityViewInteract
3838
typedef vtkVirtualRealityViewInteractor Self;
3939

4040
vtkTypeMacro(vtkVirtualRealityViewInteractor,vtkOpenVRRenderWindowInteractor);
41-
void PrintSelf(ostream& os, vtkIndent indent);
41+
void PrintSelf(ostream& os, vtkIndent indent) override;
4242

43-
virtual void SetInteractorStyle(vtkInteractorObserver*);
43+
virtual void SetInteractorStyle(vtkInteractorObserver*) override;
4444

4545
///@{
4646
/// Define Slicer specific heuristic for handling complex gestures.

VirtualReality/SubjectHierarchyPlugins/qSlicerSubjectHierarchyVirtualRealityPlugin.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@ class Q_SLICER_VIRTUALREALITY_SUBJECT_HIERARCHY_PLUGINS_EXPORT qSlicerSubjectHie
4141

4242
public:
4343
/// Get item context menu item actions to add to tree view
44-
virtual QList<QAction*> itemContextMenuActions()const;
44+
QList<QAction*> itemContextMenuActions()const override;
4545

4646
/// Show context menu actions valid for a given subject hierarchy item.
4747
/// \param itemID Subject Hierarchy item to show the context menu items for
48-
virtual void showContextMenuActionsForItem(vtkIdType itemID);
48+
void showContextMenuActionsForItem(vtkIdType itemID) override;
4949

5050
/// Get selectable flag on given item's node(s).
5151
/// \return True if all are selectable, false if at least one of the nodes are not

VirtualReality/qSlicerVirtualRealityModule.h

Lines changed: 10 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -51,14 +51,14 @@ class Q_SLICER_QTMODULES_VIRTUALREALITY_EXPORT
5151

5252
qSlicerGetTitleMacro(QTMODULE_TITLE);
5353

54-
virtual QString helpText()const;
55-
virtual QString acknowledgementText()const;
56-
virtual QStringList contributors()const;
54+
QString helpText()const override;
55+
QString acknowledgementText()const override;
56+
QStringList contributors()const override;
5757

58-
virtual QIcon icon()const;
58+
QIcon icon()const override;
5959

60-
virtual QStringList categories()const;
61-
virtual QStringList dependencies() const;
60+
QStringList categories()const override;
61+
QStringList dependencies() const override;
6262

6363
Q_INVOKABLE bool isToolBarVisible();
6464
Q_INVOKABLE QToolBar* toolBar();
@@ -74,21 +74,21 @@ public slots:
7474

7575
/// Set MRML scene for the module. Updates the default view settings based on
7676
/// the application settings.
77-
virtual void setMRMLScene(vtkMRMLScene* scene);
77+
void setMRMLScene(vtkMRMLScene* scene) override;
7878

7979
protected slots:
8080
void onViewNodeModified();
8181

8282
protected:
8383

8484
/// Initialize the module
85-
virtual void setup();
85+
void setup() override;
8686

8787
/// Create and return the widget representation associated to this module
88-
virtual qSlicerAbstractModuleRepresentation* createWidgetRepresentation();
88+
qSlicerAbstractModuleRepresentation* createWidgetRepresentation() override;
8989

9090
/// Create and return the logic associated to this module
91-
virtual vtkMRMLAbstractLogic* createLogic();
91+
vtkMRMLAbstractLogic* createLogic() override;
9292

9393
protected:
9494
QScopedPointer<qSlicerVirtualRealityModulePrivate> d_ptr;

VirtualReality/qSlicerVirtualRealityModuleWidget.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@ protected slots:
6161
protected:
6262
QScopedPointer<qSlicerVirtualRealityModuleWidgetPrivate> d_ptr;
6363

64-
virtual void setup();
64+
void setup() override;
6565

6666
double getMagnificationFromPower(double powerOfTen);
6767
double getPowerFromMagnification(double magnification);

0 commit comments

Comments
 (0)