cleanup

Author: DerThorsten

.github/workflows/deploy-github-page.yml

@@ -33,7 +33,6 @@ jobs:
           environment-file: environment-wasm-build.yml
           init-shell: bash
           environment-name: xeus-python-wasm-build
- 
       - name: Set ncpus
         run: echo "ncpus=$(nproc --all)" >> $GITHUB_ENV
 
@@ -51,7 +50,6 @@ jobs:
           URL=https://github.com/DerThorsten/xeus-python-shell/archive/refs/heads/libuv.zip 
           curl -L $URL -o xeus-python-shell-libuv.zip
           unzip xeus-python-shell-libuv.zip
-        
 
           export PREFIX=$MAMBA_ROOT_PREFIX/envs/xeus-python-wasm-host
           echo "PREFIX=$PREFIX" >> $GITHUB_ENV
@@ -66,9 +64,6 @@ jobs:
 
           emmake make -j${{ env.ncpus }} install
 
-
-          
-
       - name: Jupyter Lite integration
         shell: bash -l {0}
         run: |

.github/workflows/main.yml

@@ -66,13 +66,6 @@ jobs:
             ${{ env.CMAKE_EXTRA_ARGS }}
         working-directory: build
 
-      # - name: Build
-      #   run: cmake --build . --target xeus-python --verbose -j ${{ runner.os == 'macOS' && 3 || 4 }}
-      #   working-directory: build
-      
-      # - name: Inspect build lib
-      #   run: nm build/libxeus-python.so | grep raw_interpreter
-
       - name: Build all targets
         run: cmake --build . --verbose -j ${{ runner.os == 'macOS' && 3 || 4 }}
         working-directory: build
@@ -118,7 +111,6 @@ jobs:
         shell: cmd /C call {0}
         run: pip install git+https://github.com/DerThorsten/xeus-python-shell.git@libuv
 
-
       - name: Static build option
         if: matrix.build_type == 'static_build'
         run: |
@@ -163,8 +155,4 @@ jobs:
         run: |
           test_xeus_python
         timeout-minutes: 4
-        working-directory: build\test
-
-
-   
-
+        working-directory: build\test

include/xeus-python/xinterpreter.hpp

@@ -101,21 +101,7 @@ namespace xpyt
         bool m_redirect_output_enabled;
         bool m_redirect_display_enabled;
 
-    private:
-
-        // helper methods:
-        void execute_request_impl_sync(send_reply_callback cb,
-                                  int execution_counter,
-                                  const std::string& code,
-                                  xeus::execute_request_config config,
-                                  nl::json user_expressions);
-        
-        void execute_request_impl_async(send_reply_callback cb,
-                                  int execution_counter,
-                                  const std::string& code,
-                                  xeus::execute_request_config config,
-                                  nl::json user_expressions);
-                                
+    private:                    
 
         virtual void instanciate_ipython_shell();
         virtual bool use_jedi_for_completion() const;

src/main.cpp

@@ -122,14 +122,9 @@ int main(int argc, char* argv[])
 
     std::unique_ptr<xeus::xcontext> context = xeus::make_zmq_context();
 
-
-
-
+    // we want to use **the same global dict everywhere**
     py::dict globals = py::globals();    
 
-
-    
-
     // Instantiating the xeus xinterpreter
     bool raw_mode = xpyt::extract_option("-r", "--raw", argc, argv);
     using interpreter_ptr = std::unique_ptr<xeus::xinterpreter>;
@@ -159,11 +154,7 @@ int main(int argc, char* argv[])
     debugger_config["python"] = executable;
 
 
-
-
-
-
-
+    // Factory to create the debugger with the global dict
     auto make_the_debugger = [globals](
                             xeus::xcontext& context,
                             const xeus::xconfiguration& config,
@@ -179,15 +170,7 @@ int main(int argc, char* argv[])
             session_id,
             debugger_config);
     };
-            
-
-
-
-
-
-
-
-
+        
     if (!connection_filename.empty())
     {
         xeus::xconfiguration config = xeus::load_configuration(connection_filename);