Update fast_tsne.m#104
Conversation
line 256: for cmd to run fit-tsne, it should be FItSNE.exe rather than fast_tsne to be used for calculation
|
Thanks for the PR--and so sorry for the long delay. That's only for Windows though. We should have separate call-lines for Windows and non-Windows (i.e. OS X and Linux). |
|
This change would world only on Windows as stated. I don't have a windows computer, but does the binary have a .exe at the end? |
You can check your binary name in the directory of fit-tsne. |
|
Yes, but I think the point is that your change may make it work on windows, but it breaks it on all other platforms. the solution is to have a check for the platform, and call the .exe on windows only |
|
@JunweiLiu0208 I believe #118 should fix your issue. can you test this if you have a windows computer? |
if ispc |
line 256: for cmd to run fit-tsne, it should be FItSNE.exe rather than fast_tsne to be used for calculation