apps/blade/src/app/_components/dashboard/hackathon-dashboard/point-leaderboard.tsx (1)

21-54: 🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Remove the hardcoded leaderboard cutoff from the base component.

targetDate is fixed to October 25, 2025. On June 24, 2026, targetDate <= Date.now() is always true, so non-admin users will stay in the hidden-leaderboard branch indefinitely. This breaks the new reusable/base behavior across hackathons.

💡 Suggested fix

-export function BaseHackathonPointLeaderboard({
-  hacker,
-  hId,
-}: {
+export function BaseHackathonPointLeaderboard({
+  hacker,
+  hId,
+  hideLeaderboardAfter,
+}: {
   hacker: Awaited<ReturnType<(typeof serverCall.hackerQuery)["getHacker"]>>;
   hId: string;
+  hideLeaderboardAfter?: Date;
 }) {
@@
-  const targetDate = new Date("2025-10-25T23:00:00").getTime();
+  const targetDate = hideLeaderboardAfter?.getTime() ?? Number.POSITIVE_INFINITY;

-<BaseHackathonPointLeaderboard
-  hacker={hacker}
-  hId={hackathon.name}
-/>
+<BaseHackathonPointLeaderboard
+  hacker={hacker}
+  hId={hackathon.name}
+  hideLeaderboardAfter={hackathon.endDate}
+/>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@apps/blade/src/app/_components/dashboard/hackathon-dashboard/point-leaderboard.tsx`
around lines 21 - 54, The targetDate variable in the
BaseHackathonPointLeaderboard function is hardcoded to October 25, 2025, which
means once the current date passes this fixed date, the leaderboard visibility
condition will always be true for non-admin users, breaking the reusable
behavior across different hackathons. Remove the hardcoded targetDate variable
and instead pass the leaderboard cutoff date as a configurable prop to the
BaseHackathonPointLeaderboard function, or derive it from the hackathon data
that is already being passed in as the hId parameter, allowing each hackathon
instance to specify its own cutoff date.

packages/api/src/routers/event.ts (1)

366-428: 🩺 Stability & Availability | 🔴 Critical | ⚡ Quick win

Build break: discordEventId and googleEventId are no longer declared.

The catch block still references discordEventId (Line 406) and googleEventId (Line 418), but both were declared only inside the now-commented provisioning blocks (former Lines 301 and 330). The compiler will fail with Cannot find name 'discordEventId' / 'googleEventId', and even if it compiled, this cleanup is now dead logic since no Discord/Google events are created here.

Drop the external-cleanup branches and keep only the DB-failure path.

🐛 Proposed fix to remove the now-invalid cleanup branches

       } catch (error) {
         logger.error(JSON.stringify(error, null, 2));
 
-        try {
-          await discord.api.delete(
-            Routes.guildScheduledEvent(
-              DISCORD.KNIGHTHACKS_GUILD,
-              discordEventId,
-            ),
-          );
-        } catch (cleanupErr) {
-          logger.error(JSON.stringify(cleanupErr, null, 2));
-        }
-
-        try {
-          await google.calendar.events.delete({
-            calendarId: input.isOperationsCalendar
-              ? EVENTS.DEV_GOOGLE_CALENDAR_ID
-              : EVENTS.GOOGLE_CALENDAR_ID,
-            eventId: googleEventId,
-          });
-        } catch (cleanupErr) {
-          logger.error(JSON.stringify(cleanupErr, null, 2));
-        }
-
         throw new TRPCError({
           message: "Failed to create event in the database",
           code: "BAD_REQUEST",
         });
       }

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@packages/api/src/routers/event.ts` around lines 366 - 428, The catch block in
event creation still references discordEventId and googleEventId even though
those identifiers are no longer declared in this flow. Remove the Discord and
Google cleanup branches from the error handling in the event router’s create
path, and keep only the database rollback/error logging around the
db.insert(Event) and the final TRPCError throw. Use the existing catch block in
the create-event handler to locate and simplify this dead cleanup logic.

apps/blade/src/app/_components/dashboard/hackathon-dashboard/hackathon-data.tsx (1)

201-219: 🎯 Functional Correctness | 🟠 Major

The "View Leaderboard" button currently opens an empty dialog.

Lines 201-219 wrap the button in a Dialog component, but the necessary DialogContent (or any child content) is missing. This renders the button non-functional; clicking it opens an empty modal overlay.

If the leaderboard UI is not yet ready, remove the Dialog wrapper and use a standard button or link instead to avoid dead interactions. If the dialog content exists elsewhere, ensure it is imported and placed inside the <Dialog> tags.

// Current (broken)
<Dialog>
  <DialogTrigger asChild>
    <button>View Leaderboard</button>
  </DialogTrigger>
  {/* Missing DialogContent here */}
</Dialog>

If the feature isn't ready, simplify to:

// Fixed (temporary)
<button className="..." onClick={() => window.location.href = '/leaderboard'}>
  View Leaderboard
</button>

Otherwise, add the modal structure:

<Dialog>
  <DialogTrigger asChild>
    <button>View Leaderboard</button>
  </DialogTrigger>
  <DialogContent>
    <DialogHeader>Leaderboard</DialogHeader>
    {/* Leaderboard content here */}
  </DialogContent>
</Dialog>

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In
`@apps/blade/src/app/_components/dashboard/hackathon-dashboard/hackathon-data.tsx`
around lines 201 - 219, The View Leaderboard control is wrapped in a Dialog
without any DialogContent, so it opens an empty modal. Update the
hackathon-dashboard component around the Dialog/DialogTrigger block by either
removing the Dialog wrapper and using a normal button/link if the leaderboard UI
is not ready, or by adding the missing DialogContent (with the leaderboard UI)
inside the Dialog so the trigger has real content to display.