Skip to content

Commit 0849ba1

Browse files
authored
Changed file input for script nonce compliancy
1 parent dc63dcd commit 0849ba1

11 files changed

Lines changed: 22 additions & 402 deletions

File tree

knowage/src/main/webapp/Gruntfile.js

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,7 @@ module.exports = function(grunt) {
2828
'js/lib/angular/color-picker/tinycolor-min.js',
2929
'js/lib/angular/color-picker/tinygradient.min.js',
3030
'js/lib/angular/color-picker/angularjs-color-picker.js',
31-
'js/lib/xml2js/xml2json.js',
32-
'js/lib/angular/angular-base64/angular-base64.min.js'
31+
'js/lib/xml2js/xml2json.js'
3332
],
3433
'dist/knowage-modules-bundle.js': [
3534
'node_modules/moment/min/moment-with-locales.min.js',

knowage/src/main/webapp/WEB-INF/jsp/commons/angular/angularImport.jsp

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,6 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
5656
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/document-tree/DocumentTree.js")%>"></script>
5757
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/component-tree/componentTree.js")%>"></script>
5858
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/upload-file/FileUpload.js")%>"></script>
59-
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/upload-file/FileUploadBase64.js")%>"></script>
6059
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/angular-time-picker/angularTimePicker.js")%>"></script>
6160
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/angular-list-detail/angularListDetail.js")%>"></script>
6261
<script type="text/javascript" src="<%=urlBuilder.getResourceLink(request,"/js/src/angular_1.4/tools/commons/angular-list-detail/angular2Col.js")%>"></script>

knowage/src/main/webapp/js/src/angular_1.4/tools/commons/upload-file/FileUploadBase64.js

Lines changed: 0 additions & 103 deletions
This file was deleted.

knowage/src/main/webapp/js/src/angular_1.4/tools/commons/upload-file/template/file-upload-base64.html

Lines changed: 0 additions & 11 deletions
This file was deleted.

knowagecockpitengine/src/main/webapp/js/src/angular_1.4/cockpit/directives/cockpit-widget/widget/imageWidget/imageWidget.js

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,17 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
134134
$scope.uploadImg = {};
135135
$scope.user = sbiModule_user;
136136

137+
138+
$timeout(function() {
139+
var input = document.querySelector('#imageWidgetFileUpload'); // usa l'id corretto
140+
if (input) {
141+
input.addEventListener('change', function(event) {
142+
$scope.setFile(event.target);
143+
});
144+
}
145+
}, 0);
146+
147+
137148
$scope.saveConfiguration = function() {
138149
if ($scope.model.content.imgId == undefined) {
139150
$scope.showAction($scope.translate.load('sbi.cockpit.widget.image.missingimg'));
@@ -154,7 +165,7 @@ along with this program. If not, see <http://www.gnu.org/licenses/>.
154165
};
155166

156167
$scope.setFile = function(element) {
157-
var max = 10 * 1024 * 1024;;
168+
var max = 10 * 1024 * 1024;
158169
if (element.files && element.files[0] && element.files[0].size > max) {
159170
$scope.showAction('File too large. Max file size is: ' + max / 1024 / 1024 + 'MB');
160171
element.value = null;

knowagecockpitengine/src/main/webapp/js/src/angular_1.4/cockpit/directives/cockpit-widget/widget/imageWidget/templates/imageWidgetEditPropertyTemplate.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@ <h2>{{translate.format(translate.load('sbi.cockpit.widget.configuration'),transl
1515
<!-- file-upload flex id="ImageUpload" ng-model="uploadImg"></file-upload-->
1616
<md-content layout="row" layout-padding>
1717
<!-- Simulate button and link the click event with the input type='file' -->
18-
<input type="file" onchange='angular.element(this).scope().setFile(this)'/>
18+
<input type="file" id="imageWidgetFileUpload" />
1919
</md-content>
2020

2121
<md-button ng-click="upload($event)" aria-label="upload Menu"

knowagecockpitengine/src/main/webapp/js/src/angular_1.4/tools/commons/upload-file/FileUpload.js

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@ angular.module('file_upload', [ 'ngMaterial', 'sbiModule'])
2424
controller: FileUploadControllerFunction,
2525
controllerAs: 'ctrl',
2626
link: function(scope, element, attrs, ctrl, transclude) {
27+
28+
var input = element.find('input')[0];
29+
input.addEventListener('change', function () {
30+
scope.ctrl.setFile(this);
31+
});
2732

2833
scope.id = "fileUpload" + Math.floor(Math.random() * 1000);
2934
if (attrs.id){
@@ -43,7 +48,8 @@ angular.module('file_upload', [ 'ngMaterial', 'sbiModule'])
4348

4449

4550
function FileUploadControllerFunction($scope,$timeout,$mdDialog,sbiModule_translate){
46-
$scope.setFile = function (element){
51+
var vm = this
52+
vm.setFile = function (element){
4753

4854
var max = $scope.fileMaxSize != undefined ? $scope.fileMaxSize : defaultFileMaxSize;
4955
var inputFile = element;

knowagecockpitengine/src/main/webapp/js/src/angular_1.4/tools/commons/upload-file/template/file-upload.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
<label ng-disabled='ngDisabled' id="{{id}}" class="md-button md-knowage-theme md-raised md-ExtraMini" md-ink-ripple for="{{id}}_input">
44
<span >{{textButton}}</span>
55
</label>
6-
<input ng-disabled='ngDisabled' id="{{id}}_input" type="file" class="ng-hide" onchange='angular.element(this).scope().setFile(this)'>
6+
<input ng-disabled='ngDisabled' id="{{id}}_input" type="file" class="ng-hide">
77
<md-input-container flex='ngDisabled' >
88
<input type='text' disabled ng-model="fileName" aria-label="file name"/>
99
</md-input-container>

knowagewhatifengine/src/main/webapp/WEB-INF/jsp/commons/angular/angularResource.jspf

Lines changed: 0 additions & 162 deletions
This file was deleted.

0 commit comments

Comments
 (0)