Skip to content

Commit 5190375

Browse files
committed
[DASHBOARD-9754] remove dataset parameters from pdf export
1 parent 08b5457 commit 5190375

1 file changed

Lines changed: 4 additions & 18 deletions

File tree

knowage-export/src/main/java/it/eng/knowage/engine/api/export/dashboard/pdf/DashboardPdfExporter.java

Lines changed: 4 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ private void exportTableWidget(PDDocument document, JSONObject widget, String wi
183183

184184
if (offset >= totalNumberOfRows) {
185185
createSelectionsRows(table, font, selections);
186-
createFiltersInformationRow(table, font, driversFromBody, parametersFromBody);
186+
createFiltersInformationRow(table, font, driversFromBody);
187187
}
188188

189189
} while (offset < totalNumberOfRows);
@@ -352,9 +352,9 @@ private void createDocumentInformationRow(BaseTable table, PDFont font, String e
352352
}
353353
}
354354

355-
private void createFiltersInformationRow(BaseTable table, PDFont font, JSONArray driversFromBody, JSONArray parametersFromBody) {
355+
private void createFiltersInformationRow(BaseTable table, PDFont font, JSONArray driversFromBody) {
356356
try {
357-
List<String> filters = extractFilters(driversFromBody, parametersFromBody);
357+
List<String> filters = extractFilters(driversFromBody);
358358
if (filters.isEmpty()) {
359359
return;
360360
}
@@ -463,7 +463,7 @@ private void createFiltersInformationRow(BaseTable table, PDFont font, JSONArray
463463
}
464464
}
465465

466-
private List<String> extractFilters(JSONArray driversFromBody, JSONArray parametersFromBody) {
466+
private List<String> extractFilters(JSONArray driversFromBody) {
467467
Set<String> filters = new LinkedHashSet<>();
468468

469469
if (driversFromBody != null) {
@@ -480,20 +480,6 @@ private List<String> extractFilters(JSONArray driversFromBody, JSONArray paramet
480480
}
481481
}
482482

483-
if (parametersFromBody != null) {
484-
for (int i = 0; i < parametersFromBody.length(); i++) {
485-
JSONObject parameter = parametersFromBody.optJSONObject(i);
486-
if (parameter == null) {
487-
continue;
488-
}
489-
String name = firstNonEmpty(parameter.optString("label"), parameter.optString("name"), parameter.optString("urlName"));
490-
String value = extractFilterValue(parameter);
491-
if (!stringIsEmpty(name) && !stringIsEmpty(value) && !"null".equalsIgnoreCase(value)) {
492-
filters.add(name + ": " + value);
493-
}
494-
}
495-
}
496-
497483
return new ArrayList<>(filters);
498484
}
499485

0 commit comments

Comments
 (0)