[KNOWAGE-9771] conditionally remove style from excel export: change condition strategy

Author: eng-dedalus

knowage-export/src/main/java/it/eng/knowage/engine/api/export/dashboard/excel/DashboardExcelExporter.java

@@ -60,9 +60,9 @@ public class DashboardExcelExporter extends DashboardExporter {
     private static final String CONFIG_NAME_FOR_EXPORT_SCRIPT_PATH = "internal.nodejs.chromium.export.path";
     private static final String CONFIG_NAME_FOR_DRIVERS_SHEET_EXPORT = "DASHBOARD.EXPORT.SHOW_DRIVERS_SHEET";
     private static final String CONFIG_NAME_FOR_SELECTIONS_SHEET_EXPORT = "DASHBOARD.EXPORT.SHOW_SELECTIONS_SHEET";
-    private static final String CONFIG_NAME_FOR_DISABLE_STYLE = "DASHBOARD.XLSX.EXPORT.DISABLE_STYLE";
     private static final String SCRIPT_NAME = "cockpit-export-xls.js";
     private static final String DOCUMENT_NAME = "";
+    private static final String XLSX_STYLE_ENABLED = "xlsxStyleEnabled";
     private String role;
     private String requestURL = "";
     private String organization = "";
@@ -91,6 +91,24 @@ public DashboardExcelExporter(JSONObject body, String role, String requestUrl, S
         this.organization = organization;
     }
 
+    static boolean isXlsxStyleEnabled(JSONObject body, boolean isDashboardSingleWidgetExport) {
+        if (body == null) {
+            return true;
+        }
+        if (isDashboardSingleWidgetExport) {
+            return body.optBoolean(XLSX_STYLE_ENABLED, true);
+        }
+        JSONObject configuration = body.optJSONObject("configuration");
+        if (configuration == null) {
+            return true;
+        }
+        JSONObject menuWidgets = configuration.optJSONObject("menuWidgets");
+        if (menuWidgets == null) {
+            return true;
+        }
+        return menuWidgets.optBoolean(XLSX_STYLE_ENABLED, true);
+    }
+
     public byte[] getScheduledBinaryData(String documentLabel) throws IOException, InterruptedException {
         try {
             Path outputDir;
@@ -214,12 +232,7 @@ public byte[] getDashboardBinaryData(JSONObject body, boolean isDashboardSingleW
             JSONArray driversFromBody = getDrivers(body);
             JSONObject drivers = transformDriversForDatastore(driversFromBody);
             JSONArray parameters = getParametersFromBody(body);
-
-            IConfigDAO configsDao = DAOFactory.getSbiConfigDAO();
-            Optional<Config> disableStyleCfg = configsDao.loadConfigParametersByLabelIfExist(CONFIG_NAME_FOR_DISABLE_STYLE);
-            if (disableStyleCfg.isPresent() && disableStyleCfg.get().isActive()) {
-                this.disableBasicStyle = Boolean.parseBoolean(disableStyleCfg.get().getValueCheck());
-            }
+            this.disableBasicStyle = !isXlsxStyleEnabled(body, isDashboardSingleWidgetExport);
 
             if (isDashboardSingleWidgetExport) {
                 if (body.has("datasetDrivers") && body.getJSONArray("datasetDrivers") != null && body.getJSONArray("datasetDrivers").length() > 0) {
@@ -233,6 +246,7 @@ public byte[] getDashboardBinaryData(JSONObject body, boolean isDashboardSingleW
             }
 
 
+            IConfigDAO configsDao = DAOFactory.getSbiConfigDAO();
             Optional<Config> selectionsCfg = configsDao.loadConfigParametersByLabelIfExist(CONFIG_NAME_FOR_SELECTIONS_SHEET_EXPORT);
 
             if (selectionsCfg.isPresent() && selectionsCfg.get().isActive() && Boolean.parseBoolean(selectionsCfg.get().getValueCheck()) && !selections.isEmpty()) {
@@ -280,6 +294,7 @@ public byte[] getPivotBinaryData(JSONObject body) {
             throw new SpagoBIRuntimeException("Unable to get template for dashboard");
         }
         try {
+            this.disableBasicStyle = !isXlsxStyleEnabled(body, true);
             Map<String, Map<String, Object>> selections = getSelections(body);
 
             JSONArray driversFromBody = getDrivers(body);

knowage/src/main/resources/it/eng/spagobi/commons/initializers/metadata/config/configs.xml

@@ -682,8 +682,5 @@
 			description="If true, drivers and selections sheet will be included in the exported workbook (cockpit xlsx export)" isActive="true"
 			valueCheck="false" valueType="STRING" category="GENERIC_CONFIGURATION" />
 
-	<CONFIG label="DASHBOARD.XLSX.EXPORT.DISABLE_STYLE" name="Disables style in dashboard xlsx export"
-			description="If true, it disables the basic style from the xlsx export of a dashboard (this config does not affect conditional style)" isActive="true"
-			valueCheck="false" valueType="STRING" category="GENERIC_CONFIGURATION" />
 </CONFIGS>