Upgrade ECS to 12.5.22 (has no sub-dependencies) and PHPStan because why not

Kocal · Kocal · commit 079a193e5045 · 2025-08-05T08:38:18.000+02:00
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -52,7 +52,7 @@ jobs:
           # dev packages for next major version
           -   minimum-stability: 'dev'
               php-version: '8.4'
-              symfony-version: '8.0'
+              symfony-version: '8.0.x-dev'
           # lowest deps
           -   php-version: '8.1'
               dependency-version: 'lowest'
diff --git a/composer.json b/composer.json
@@ -23,8 +23,8 @@
         "symfony/process": "^6.4|^7.0|^8.0"
     },
     "require-dev": {
-        "phpstan/phpstan": "^1.11",
-        "symplify/easy-coding-standard": "^12.1.2",
+        "phpstan/phpstan": "^2.1.21",
+        "symplify/easy-coding-standard": "12.5.22",
         "symfony/framework-bundle": "^6.4|^7.0|^8.0"
     }
 }
diff --git a/src/BiomeJsBinary.php b/src/BiomeJsBinary.php
@@ -42,7 +42,7 @@ private static function isMusl(): bool
     {
         static $isMusl = null;
 
-        if (null !== $isMusl) {
+        if (is_bool($isMusl)) {
             return $isMusl;
         }
 
diff --git a/src/KocalBiomeJsBundle.php b/src/KocalBiomeJsBundle.php
@@ -10,7 +10,7 @@
 
 final class KocalBiomeJsBundle extends Bundle
 {
-    protected function createContainerExtension(): ?ExtensionInterface
+    protected function createContainerExtension(): ExtensionInterface
     {
         return new BiomeJsExtension();
     }

Original file line number	Diff line number	Diff line change
`@@ -23,8 +23,8 @@`
`23`	`23`	`"symfony/process": "^6.4\|^7.0\|^8.0"`
`24`	`24`	`},`
`25`	`25`	`"require-dev": {`
`26`		`- "phpstan/phpstan": "^1.11",`
`27`		`- "symplify/easy-coding-standard": "^12.1.2",`
	`26`	`+ "phpstan/phpstan": "^2.1.21",`
	`27`	`+ "symplify/easy-coding-standard": "12.5.22",`
`28`	`28`	`"symfony/framework-bundle": "^6.4\|^7.0\|^8.0"`
`29`	`29`	`}`
`30`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ private static function isMusl(): bool`
`42`	`42`	`{`
`43`	`43`	`static $isMusl = null;`
`44`	`44`
`45`		`- if (null !== $isMusl) {`
	`45`	`+ if (is_bool($isMusl)) {`
`46`	`46`	`return $isMusl;`
`47`	`47`	`}`
`48`	`48`
Original file line number	Diff line number	Diff line change
`@@ -10,7 +10,7 @@`
`10`	`10`
`11`	`11`	`final class KocalBiomeJsBundle extends Bundle`
`12`	`12`	`{`
`13`		`- protected function createContainerExtension(): ?ExtensionInterface`
	`13`	`+ protected function createContainerExtension(): ExtensionInterface`
`14`	`14`	`{`
`15`	`15`	`return new BiomeJsExtension();`
`16`	`16`	`}`