Replacement of the metal device's library creation#900
Closed
Just-Feeshy wants to merge 5 commits into
Closed
Conversation
Contributor
Author
|
I'm so sorry for the number of commits. I was trying to figure out what was going on with the iOS test cases and Emscripten WebGPU, and I thought that somehow changing the location caused iOS to break on both OpenGL and Metal. |
Contributor
Author
|
Just realized that there is no macro being applied to the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I moved
newDefaultLibraryfromkore_metal_device_createtokore_metal_render_pipeline_initto allow for the addition of a custom library creation function.