Use frontend.port from configuration.yaml in Onboarding#31566
Closed
dremerb wants to merge 1 commit into
Closed
Conversation
Author
|
Switching to dev branch |
Collaborator
|
Configuration for onboarding is done through envs. https://www.zigbee2mqtt.io/guide/getting-started/#onboarding |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently in Onboarding there is no way to change the port of the onboarding server.
This change makes use of the port defined for the Frontend server for
startOnboardingServerandstartFailureServer.Personally I dont think it's worth introducing dedicated configuration variables for this, therefore simply reusing frontend port definition, even if frontend may be disabled.