TDH-3754: Adding Configuration for FAQ#657
Conversation
- Bug fix for form action - Token for Img Header
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7d3674aba0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Title
FAQ WebView: add configurable status-bar visibility, decouple toolbar behavior, and fix form action formatting
Summary
This PR improves FAQ/Helpcenter rendering behavior in
KmWebViewActivityand adds a new customization setting to control FAQ status-bar visibility without breaking existing integrations.Problem
webViewClientPost()built form HTML withString.format(FORMID_ACTION)but did not pass required%sarguments.What changed
showStatusBarOnFaqPageinCustomizationSettings.isShowStatusBarOnFaqPage().trueto preserve existing behavior for clients that don’t provide this key in JSON.KmWebViewActivityKM_HELPCENTER_URL.WindowInsetsControllerCompat+ fullscreen window flag handling.onWindowFocusChanged,onResume) for device consistency.showBackButtonOnFaqPage.showStatusBarOnFaqPage.String.format(FORMID_ACTION)String.format(FORMID_ACTION, url, "post")ListKmRichMessage, header image loading now falls back fromheaderImgSrctoheaderImageUrland still appends SAS token.Behavior matrix
showBackButtonOnFaqPage=true,showStatusBarOnFaqPage=trueshowBackButtonOnFaqPage=false,showStatusBarOnFaqPage=trueshowBackButtonOnFaqPage=true,showStatusBarOnFaqPage=falseshowBackButtonOnFaqPage=false,showStatusBarOnFaqPage=falseCompatibility
true.Files changed
kommunicateui/src/main/java/io/kommunicate/ui/CustomizationSettings.javakommunicateui/src/main/java/io/kommunicate/ui/conversation/richmessaging/webview/KmWebViewActivity.javakommunicateui/src/main/java/io/kommunicate/ui/conversation/richmessaging/types/ListKmRichMessage.javaValidation
./gradlew :kommunicateui:compileDebugJavaWithJavacConfig usage (optional for consumers)
{ "showBackButtonOnFaqPage": false, "showStatusBarOnFaqPage": false }