Add argument "--version" to docklet run#3870
Conversation
|
This doesn't look right to me but I also haven't used or looked at the docker build process. @Naatan maybe you could weigh in. |
|
The diff look sane but frankly there's really no reason to be building with any other version at this stage, least that I can think of? What's your use-case @crigoda ? |
|
Well, here's what happened to me: |
|
I'm afraid the solution there is to rebuild with 12.10. Building a 12.10 build with a 10.10 version specifier can lead to unexpected results (eg. pref updater not updating certain prefs that need to be updated for v12 to operate). I'm sorry, you'll have to rebuild :\ I'll reject this PR since the use-case is not valid, but I appreciate your contribution! |
|
OK. This is not a big thing. Now I know that I must check the docklet before building. :-/ |
Hi,
When building Komodo, users have to specify version for mozilla build and komodo build.
But when using Docker, there was no option to docklet run to specify the version to run.