Interface freeze when ADE is active

[Xqua]

I am getting a comfy freeze with this error

whenever ADE is active in my custom models

[drmbt]

this has been borking a lot of my workflows too, some conflict with new comfy frontend perhaps?

[Kosinkadink]

@AustinMroz hey, do you know if ADE/ACN would need to have a JavaScript code update?

[AustinMroz]

There's been a couple of cosmetic changes I've been meaning to get around to, but I haven't observed the described freezing. Will do some digging.

[AustinMroz]

I've tried a number of frontend versions both with a bare install of only ADE and a standard install with other custom_nodes, but haven't seen any freezing.

The posted error messages have me perplexed. The error appears to originate from a browser extension (MetaMask?) and no ADE code exists in the stack trace.

I've opened a pull request for the backlogged changes I had. The old "node deprecation" code is the most likely suspect for any issues, so I'd appreciate confirmation if the error persists afterwards.

[aiXander]

This workflow here:
https://github.com/edenartlab/workflows/blob/main/workspaces/mono_workspace/workflows/texture_flow/TextureFlow.json

with comfy hash 01015bff166988c926e5ed1d03842fddc9a0f925
and ADE version 1.5.2

consistently causes the freezing problem. I've tried everything but can't fix it..

[AustinMroz]

My immense thanks. This gives me a reproduction, but it looks like this will need an upstream issue.

The provided workflow contains a "ADE_AnimateDiffSamplingSettings" node which is bugged to contain two image_inject inputs. One of which appears to be an incorrectly converted seed_override widget. Attached is a minimal workflow consisting of just the bugged Sampling Settings. Loading this workflow will instantly cause a crash even when no frontend plugins are loaded.

samplesettings.json

I've not yet identified how a bugged workflow like this is created, and want to avoid pointing fingers until I track it down, but loading a workflow should not cause things to freeze like this.

[aiXander]

@AustinMroz
@drmbt and I just manually fixed the workflow by freshly copying the settings node. I've re-uploaded the fixed version on top of the same url (cause I'm linking to it in my YouTube video here) so just wanted to let you know in case you want to link people to the broken workflow.

Fixed version:
https://github.com/edenartlab/workflows/blob/main/workspaces/mono_workspace/workflows/texture_flow/TextureFlow.json
Broken version:
https://github.com/edenartlab/workflows/blob/main/workspaces/mono_workspace/workflows/texture_flow/TextureFlow_broken.json

I'm not entirely sure how this happened but I created this workflow using a pretty old version of comfy / ADE (at least several months old, I can find the exact commits if you want) and then noticed that it was bugged in a fresh comfy/ADE install.

Thanks for looking into this!

[AustinMroz]

Fabulous. Any leads for tracking down what went wrong would be a greatly appreciated. Like Kosinkadink, I put great value in keeping workflows forward compatible, and I would particularly like to avoid less savy users running into the issue and being unable to recover a workflow.

At this time, I'm reasonably confident that the issue is unrelated to any of the js code I've made for ADE. So my primary leads are

• A fairly recent removal of "noise_calib" from ADE sampling settings.
  • I myself submitted a fix for links being misdirected from converted widgets if an input is added several months back, so there's precedence for an edge case here.
• Recent frontend churn with converted widgets. The ComfyUI commit (which hopefully has a bundled frontend version) would be helpful here.