Reduce impact. Reset repoProviders caches. (#272)

* Reduce impact

* Reset caches on start/stop

* Relax checkstyle

Author: KostyaSha

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/GitHubRepoProvider.java

@@ -36,12 +36,23 @@ public abstract class GitHubRepoProvider extends AbstractDescribableImpl<GitHubR
     @CheckForNull
     public abstract GitHub getGitHub(GitHubTrigger trigger);
 
+    /**
+     * Called on trigger start. I.e. reset cache after some changes.
+     */
+    public void onTriggerStart() {}
+
+    /**
+     * Called on trigger stop. I.e. reset cache after some changes.
+     */
+    public void onTriggerStop() {}
+
     /**
      * alive connection to remote repo.
      */
     @CheckForNull
     public abstract GHRepository getGHRepository(GitHubTrigger trigger);
 
+
     public abstract static class GitHubRepoProviderDescriptor
             extends Descriptor<GitHubRepoProvider> {
         @Nonnull

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/GitHubRepository.java

@@ -62,23 +62,24 @@ public void actualise(@Nonnull GHRepository ghRepository, @Nonnull TaskListener
         PrintStream logger = listener.getLogger();
         // just in case your organisation decided to change domain
         // take into account only repo/name
-        if (isNull(fullName) || !fullName.equals(ghRepository.getFullName())) {
+        if (isNull(fullName) || !fullName.equalsIgnoreCase(ghRepository.getFullName())) {
             logger.printf("Repository full name changed from '%s' to '%s'.\n", fullName, ghRepository.getFullName());
             fullName = ghRepository.getFullName();
             changed = true;
         }
 
-        if (isNull(githubUrl) || !githubUrl.equals(ghRepository.getHtmlUrl())) {
+        if (isNull(githubUrl)
+                || !githubUrl.toExternalForm().equalsIgnoreCase(ghRepository.getHtmlUrl().toExternalForm())) {
             logger.printf("Changing GitHub url from '%s' to '%s'.\n", githubUrl, ghRepository.getHtmlUrl());
             githubUrl = ghRepository.getHtmlUrl();
         }
 
-        if (isNull(gitUrl) || !gitUrl.equals(ghRepository.getGitTransportUrl())) {
+        if (isNull(gitUrl) || !gitUrl.equalsIgnoreCase(ghRepository.getGitTransportUrl())) {
             logger.printf("Changing Git url from '%s' to '%s'.\n", gitUrl, ghRepository.getGitTransportUrl());
             gitUrl = ghRepository.getGitTransportUrl();
         }
 
-        if (isNull(sshUrl) || !sshUrl.equals(ghRepository.getSshUrl())) {
+        if (isNull(sshUrl) || !sshUrl.equalsIgnoreCase(ghRepository.getSshUrl())) {
             logger.printf("Changing SSH url from '%s' to '%s'.\n", sshUrl, ghRepository.getSshUrl());
             sshUrl = ghRepository.getSshUrl();
         }

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/GitHubTrigger.java

@@ -111,6 +111,7 @@ public void setRepoName(GitHubRepositoryName repoName) {
     @Override
     public void start(Job<?, ?> project, boolean newInstance) {
         repoName = null; // reset cache
+        getRepoProviders().forEach(GitHubRepoProvider::onTriggerStart);
         super.start(project, newInstance);
     }
 
@@ -187,6 +188,7 @@ public GitHubErrorsAction getErrorsAction() {
     @Override
     public void stop() {
         repoName = null;
+        getRepoProviders().forEach(GitHubRepoProvider::onTriggerStop);
         //TODO clean hooks?
         if (nonNull(job)) {
             LOG.info("Stopping '{}' for project '{}'", getDescriptor().getDisplayName(), job.getFullName());

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/repoprovider/GitHubPluginRepoProvider.java

@@ -89,6 +89,18 @@ public boolean isManageHooks(GitHubTrigger trigger) {
         return isManageHooks() && GitHubPlugin.configuration().isManageHooks();
     }
 
+    @Override
+    public void onTriggerStart() {
+        gitHub = null;
+        remoteRepository = null;
+    }
+
+    @Override
+    public void onTriggerStop() {
+        gitHub = null;
+        remoteRepository = null;
+    }
+
     @Nonnull
     @Override
     public synchronized GitHub getGitHub(GitHubTrigger trigger) {
@@ -157,6 +169,7 @@ protected Object readResolve() {
 
     @Extension
     public static class DescriptorImpl extends GitHubRepoProviderDescriptor {
+        @Nonnull
         @Override
         public String getDisplayName() {
             return "GitHub Plugin Repository Provider";

github-pullrequest-plugin/src/test/resources/checkstyle/checkstyle.xml

@@ -159,8 +159,9 @@
         <module name="ParenPad"/>
         <module name="TypecastParenPad"/>
         <module name="WhitespaceAfter"/>
-        <module name="WhitespaceAround"/>
-
+        <module name="WhitespaceAround">
+            <property name="allowEmptyMethods" value="true"/>
+        </module>
 
         <!-- Modifier Checks                                    -->
         <!-- See http://checkstyle.sf.net/config_modifiers.html -->