WIP Symbols (#118)

* Draft symbols.

* change

* Update pom.xml

Author: KostyaSha

github-pullrequest-plugin/pom.xml

@@ -225,6 +225,14 @@
             <optional>true</optional>
         </dependency>
 
+        <!-- https://wiki.jenkins-ci.org/display/JENKINS/Structs+plugin -->
+        <dependency>
+            <groupId>org.jenkins-ci.plugins</groupId>
+            <artifactId>structs</artifactId>
+            <version>1.14</version>
+            <optional>true</optional>
+        </dependency>
+
         <!-- workflow for tests -->
         <dependency>
             <groupId>org.jenkins-ci.plugins</groupId>

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/GitHubBranchTrigger.java

@@ -11,6 +11,7 @@
 import hudson.Extension;
 import hudson.model.Job;
 import hudson.triggers.Trigger;
+import org.jenkinsci.Symbol;
 import org.jenkinsci.plugins.github.pullrequest.GitHubPRTriggerMode;
 import org.jenkinsci.plugins.github.pullrequest.restrictions.GitHubPRBranchRestriction;
 import org.jenkinsci.plugins.github.pullrequest.restrictions.GitHubPRUserRestriction;
@@ -327,6 +328,7 @@ private static boolean isSupportedTriggerMode(GitHubPRTriggerMode mode) {
         return mode != LIGHT_HOOKS;
     }
 
+    @Symbol("githubBranches")
     @Extension
     public static class DescriptorImpl extends GitHubTriggerDescriptor {
 

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/events/impl/GitHubBranchCommitEvent.java

@@ -11,6 +11,7 @@
 import hudson.Extension;
 import hudson.model.TaskListener;
 import net.sf.json.JSONObject;
+import org.jenkinsci.Symbol;
 import org.kohsuke.accmod.Restricted;
 import org.kohsuke.accmod.restrictions.NoExternalUse;
 import org.kohsuke.github.GHBranch;
@@ -130,6 +131,7 @@ private GitHubBranchCause check(GHBranch remoteBranch, Function<GitHubBranchComm
         return cause;
     }
 
+    @Symbol("commit")
     @Extension
     public static class DescriptorImpl extends GitHubBranchEventDescriptor {
         @Override
@@ -140,6 +142,7 @@ public boolean configure(StaplerRequest req, JSONObject formData) throws FormExc
             return super.configure(req, formData);
         }
 
+        @Nonnull
         @Override
         public final String getDisplayName() {
             return DISPLAY_NAME;

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/events/impl/GitHubBranchCreatedEvent.java

@@ -7,6 +7,7 @@
 import com.github.kostyasha.github.integration.generic.GitHubBranchDecisionContext;
 import hudson.Extension;
 import hudson.model.TaskListener;
+import org.jenkinsci.Symbol;
 import org.kohsuke.github.GHBranch;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.slf4j.Logger;
@@ -57,6 +58,7 @@ public GitHubBranchCause check(@Nonnull GitHubBranchDecisionContext context) thr
         return cause;
     }
 
+    @Symbol("branchCreated")
     @Extension
     public static class DescriptorImpl extends GitHubBranchEventDescriptor {
         @Nonnull

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/events/impl/GitHubBranchDeletedEvent.java

@@ -7,6 +7,7 @@
 import com.github.kostyasha.github.integration.generic.GitHubBranchDecisionContext;
 import hudson.Extension;
 import hudson.model.TaskListener;
+import org.jenkinsci.Symbol;
 import org.kohsuke.github.GHBranch;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.slf4j.Logger;
@@ -48,6 +49,7 @@ public GitHubBranchCause check(@Nonnull GitHubBranchDecisionContext context) thr
         return cause;
     }
 
+    @Symbol("deleted")
     @Extension
     public static class DescriptorImpl extends GitHubBranchEventDescriptor {
         @Nonnull

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/events/impl/GitHubBranchHashChangedEvent.java

@@ -7,6 +7,7 @@
 import com.github.kostyasha.github.integration.generic.GitHubBranchDecisionContext;
 import hudson.Extension;
 import hudson.model.TaskListener;
+import org.jenkinsci.Symbol;
 import org.kohsuke.github.GHBranch;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.slf4j.Logger;
@@ -53,6 +54,7 @@ public GitHubBranchCause check(@Nonnull GitHubBranchDecisionContext context) thr
         return cause;
     }
 
+    @Symbol("hashChanged")
     @Extension
     public static class DescriptorImpl extends GitHubBranchEventDescriptor {
         @Nonnull

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/events/impl/GitHubBranchRestrictionFilter.java

@@ -6,6 +6,7 @@
 import com.github.kostyasha.github.integration.branch.events.GitHubBranchEventDescriptor;
 import com.github.kostyasha.github.integration.generic.GitHubBranchDecisionContext;
 import hudson.Extension;
+import org.jenkinsci.Symbol;
 import org.kohsuke.github.GHBranch;
 import org.kohsuke.stapler.DataBoundConstructor;
 import org.kohsuke.stapler.DataBoundSetter;
@@ -123,8 +124,10 @@ private GitHubBranchCause toCause(@Nonnull GitHubBranchDecisionContext context,
         return context.newCause(String.format(message, args), skip);
     }
 
+    @Symbol("restriction")
     @Extension
     public static class Descriptor extends GitHubBranchEventDescriptor {
+        @Nonnull
         @Override
         public String getDisplayName() {
             return DISPLAY_NAME;

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/events/impl/commitchecks/impl/GitHubBranchCommitMessageCheck.java

@@ -6,6 +6,7 @@
 import com.github.kostyasha.github.integration.branch.events.impl.commitchecks.GitHubBranchCommitCheckDescriptor;
 import hudson.Extension;
 import hudson.ExtensionPoint;
+import org.jenkinsci.Symbol;
 import org.kohsuke.github.GHBranch;
 import org.kohsuke.github.GHCommit;
 import org.kohsuke.github.GHCompare.Commit;
@@ -132,6 +133,7 @@ private GitHubBranchCause toCause(GHBranch remoteBranch, GitHubBranchRepository
         return new GitHubBranchCause(remoteBranch, localRepo, String.format(message, args), skip);
     }
 
+    @Symbol("commitMessagePattern")
     @Extension
     public static class DescriptorImpl extends GitHubBranchCommitCheckDescriptor {
         @Nonnull

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/repoprovider/GitHubPluginRepoProvider.java

@@ -7,6 +7,7 @@
 import com.google.common.base.Optional;
 import hudson.Extension;
 import org.apache.commons.lang3.BooleanUtils;
+import org.jenkinsci.Symbol;
 import org.jenkinsci.plugins.github.GitHubPlugin;
 import org.jenkinsci.plugins.github.internal.GHPluginConfigException;
 import org.jenkinsci.plugins.github.util.misc.NullSafePredicate;
@@ -167,6 +168,7 @@ protected Object readResolve() {
         return this;
     }
 
+    @Symbol("githubPlugin")
     @Extension
     public static class DescriptorImpl extends GitHubRepoProviderDescriptor {
         @Nonnull

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/multibranch/GitHubBranchBuildStrategy.java

@@ -8,6 +8,7 @@
 import jenkins.scm.api.SCMRevision;
 import jenkins.scm.api.SCMSource;
 import jenkins.scm.api.SCMSourceDescriptor;
+import org.jenkinsci.Symbol;
 import org.kohsuke.stapler.DataBoundConstructor;
 
 import javax.annotation.Nonnull;
@@ -35,6 +36,7 @@ public boolean isAutomaticBuild(SCMSource source, SCMHead head, SCMRevision revi
         return !gr.getCause().isSkip();
     }
 
+    @Symbol("gitHubEvents")
     @Extension
     public static class DescriptorImpl extends BranchBuildStrategyDescriptor {
         @Override