Merge pull request #395 from daniel-beck/fix-legacy-checkUrl

KostyaSha · web-flow · commit 358149f481dc · 2025-11-25T03:19:45.000+03:00
Fix legacy `checkUrl` in form validation
diff --git a/github-pullrequest-plugin/src/main/resources/com/github/kostyasha/github/integration/branch/GitHubBranchTrigger/config.groovy b/github-pullrequest-plugin/src/main/resources/com/github/kostyasha/github/integration/branch/GitHubBranchTrigger/config.groovy
@@ -22,7 +22,8 @@ f.block {
 
         f.entry(title: _("Crontab line"), field: "spec", help: "/descriptor/${TimerTrigger.getClass().getName()}/help/spec") {
             f.textbox(default: "H/5 * * * *",
-                    checkUrl: "'descriptorByName/hudson.triggers.TimerTrigger/checkSpec?value=' + encodeURIComponent(this.value)")
+                    checkUrl: "descriptorByName/hudson.triggers.TimerTrigger/checkSpec",
+                    checkDependsOn: "")
         }
 
         f.entry(title: "Set status before build", field: "preStatus") {
diff --git a/github-pullrequest-plugin/src/main/resources/org/jenkinsci/plugins/github/pullrequest/GitHubPRTrigger/config.groovy b/github-pullrequest-plugin/src/main/resources/org/jenkinsci/plugins/github/pullrequest/GitHubPRTrigger/config.groovy
@@ -22,7 +22,8 @@ f.block {
 
         f.entry(title: _("Crontab line"), field: "spec", help: "/descriptor/${TimerTrigger.getClass().getName()}/help/spec") {
             f.textbox(default: "H/5 * * * *",
-                    checkUrl: "'descriptorByName/hudson.triggers.TimerTrigger/checkSpec?value=' + encodeURIComponent(this.value)")
+                    checkUrl: "descriptorByName/hudson.triggers.TimerTrigger/checkSpec",
+                    checkDependsOn: "")
         }
 
         f.entry(title: "Set status before build", field: "preStatus") {

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,8 @@ f.block {`
`22`	`22`
`23`	`23`	`f.entry(title: _("Crontab line"), field: "spec", help: "/descriptor/${TimerTrigger.getClass().getName()}/help/spec") {`
`24`	`24`	`f.textbox(default: "H/5 * * * *",`
`25`		`- checkUrl: "'descriptorByName/hudson.triggers.TimerTrigger/checkSpec?value=' + encodeURIComponent(this.value)")`
	`25`	`+ checkUrl: "descriptorByName/hudson.triggers.TimerTrigger/checkSpec",`
	`26`	`+ checkDependsOn: "")`
`26`	`27`	`}`
`27`	`28`
`28`	`29`	`f.entry(title: "Set status before build", field: "preStatus") {`