API for hidding delayed errors (#228)

* API for hidding delayed errors

* Show job UI only when visible error available

Author: KostyaSha

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/errors/GitHubError.java

@@ -20,6 +20,13 @@ public GitHubError(@Nonnull String description) {
     @Nonnull
     public abstract String getTitle();
 
+    /**
+     * Whether to show error on job page. Useful when error visibility will be known after delay.
+     */
+    public boolean isVisible() {
+        return true;
+    }
+
     /**
      * Raw displayed html content as description.
      */

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/generic/errors/GitHubErrorsAction.java

@@ -23,6 +23,17 @@ public GitHubErrorsAction(@Nonnull String description) {
         this.description = description;
     }
 
+    public boolean hasVisibleErrors() {
+        boolean hasVisible = false;
+        for (GitHubError error : errors) {
+            if (error.isVisible()) {
+                hasVisible = true;
+                break;
+            }
+        }
+        return hasVisible;
+    }
+
     @Nonnull
     public String getDescription() {
         return description;

github-pullrequest-plugin/src/main/resources/com/github/kostyasha/github/integration/generic/errors/GitHubErrorsAction/jobMain.groovy

@@ -1,27 +1,22 @@
 package com.github.kostyasha.github.integration.generic.errors.GitHubErrorsAction
 
-import com.github.kostyasha.github.integration.generic.errors.GitHubError
-import lib.FormTagLib
-import lib.LayoutTagLib
-
-def f = namespace(FormTagLib);
-def l = namespace(LayoutTagLib);
 def t = namespace("/lib/hudson")
 def st = namespace("jelly:stapler");
-def j = namespace("jelly:core");
 
-if (!from?.errors?.isEmpty()) {
+if (from?.hasVisibleErrors()) {
     // indent like in hudson/model/AbstractProject/main.jelly
     table(style: "margin-left:1em;") {
         t.summary(icon: "warning.png") {
             b(from.description)
             br()
             from.getErrorsSnapshot().eachWithIndex() { error, index ->
-                b(++index  + " " + error.title)
-                div(style: "margin-left:2em") {
-                    raw(error.getHtmlDescription())
+                if (error.isVisible()) {
+                    b(++index + " " + error.title)
+                    div(style: "margin-left:2em") {
+                        raw(error.getHtmlDescription())
+                    }
+                    st.include(page: "index.jelly", it: error, optional: true)
                 }
-                st.include(page: "index.jelly", it: error, optional: true)
             }
         }
     }