- fixed button used to trigger branch rebuild (#188)

Author: jgangemi

github-pullrequest-plugin/src/main/java/com/github/kostyasha/github/integration/branch/GitHubBranchRepository.java

@@ -106,6 +106,7 @@ public String getUrlName() {
         return map;
     }
 
+    @Override
     @RequirePOST
     public FormValidation doClearRepo() throws IOException {
         FormValidation result;
@@ -127,6 +128,7 @@ public FormValidation doClearRepo() throws IOException {
     }
 
     @Override
+    @RequirePOST
     public FormValidation doRunTrigger() throws IOException {
         FormValidation result;
         try {
@@ -153,6 +155,7 @@ public FormValidation doRunTrigger() throws IOException {
     }
 
     @Override
+    @RequirePOST
     public FormValidation doRebuildFailed() throws IOException {
         FormValidation result;
         try {
@@ -177,6 +180,7 @@ public FormValidation doRebuildFailed() throws IOException {
     }
 
     @Override
+    @RequirePOST
     public FormValidation doRebuild(StaplerRequest req) throws IOException {
         FormValidation result;
 

github-pullrequest-plugin/src/main/resources/com/github/kostyasha/github/integration/branch/GitHubBranchRepository/index.groovy

@@ -2,6 +2,7 @@ package com.github.kostyasha.github.integration.branch.GitHubBranchRepository
 
 import com.github.kostyasha.github.integration.branch.GitHubBranchCause
 import hudson.model.Item
+import org.apache.commons.lang3.StringEscapeUtils
 
 def f = namespace(lib.FormTagLib);
 def l = namespace(lib.LayoutTagLib);
@@ -18,6 +19,15 @@ def makeBuildItem(def runs) {
     }
 }
 
+def escapeBranchName(def branchName) {
+   // escape anything that isn't alphanumeric
+   return StringEscapeUtils.escapeEcmaScript(branchName);
+}
+
+def makeRebuildId(def branchName) {
+    // replace anything that isn't alphanumeric so it's valid html
+    return ("rebuildResult" + branchName).replaceAll(/([^a-zA-Z0-9])/, '');
+}
 
 l.layout(title: "GitHub Branch Status") {
     st.include(page: "sidepanel", it: my.job)
@@ -55,9 +65,10 @@ l.layout(title: "GitHub Branch Status") {
                 if (h.hasPermission(Item.BUILD)) {
                     tr() {
                         td() {
-                            def rebuildId = "rebuildResult" + branch.name;
+                            def rebuildId = makeRebuildId(branch.name);
+                            def escaped = escapeBranchName(branch.name);
                             form(method: "post", action: "rebuild",
-                                    onsubmit: "return callFeature(this, ${rebuildId}, {'branch' : ${branch.name} })") {
+                                    onsubmit: "return callFeature(this, ${rebuildId}, {'branchName' : '${escaped}' })") {
                                 f.submit(value: _("Rebuild"))
                                 div(id: rebuildId)
                             }