Skip to content

Commit 856e659

Browse files
committed
bumping to gradle 9.5.0, updating build convention dependencies
1 parent b7ca664 commit 856e659

18 files changed

Lines changed: 24 additions & 23 deletions

File tree

build-logic/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ ktlint {
2121
dependencies {
2222
// Add a dependency on the Kotlin Gradle plugin so that convention plugins can apply it.
2323
implementation(libs.kotlin.gradle.plugin)
24-
implementation("org.gradle.kotlin:gradle-kotlin-dsl-plugins:$expectedKotlinDslPluginsVersion")
24+
compileOnly("org.gradle.kotlin:gradle-kotlin-dsl-plugins:$expectedKotlinDslPluginsVersion")
2525

2626
// So we can create pretty tables in gradle task outputs, parse json, and rename to camelCase
2727
implementation(libs.dataframe.release.core)

build-logic/src/main/kotlin/dfbuild.buildConfig.gradle.kts

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
1-
@file:OptIn(ExperimentalBuildToolsApi::class)
1+
@file:OptIn(ExperimentalBuildToolsApi::class, ExperimentalKotlinGradlePluginApi::class)
22

33
import org.gradle.kotlin.dsl.support.uppercaseFirstChar
44
import org.jetbrains.kotlin.buildtools.api.ExperimentalBuildToolsApi
5+
import org.jetbrains.kotlin.gradle.ExperimentalKotlinGradlePluginApi
56

67
plugins {
78
alias(convention.plugins.kotlinJvmCommon)
@@ -21,14 +22,14 @@ buildConfig {
2122
val buildConfigSources by kotlin.sourceSets.creating {
2223
kotlin.srcDir("build/generated/sources/buildConfig/main")
2324
}
24-
tasks.generateBuildConfig {
25+
tasks.generateBuildConfigClasses {
2526
finalizedBy(
2627
"runKtlintFormatOver${buildConfigSources.name.uppercaseFirstChar()}SourceSet",
2728
)
2829
}
2930
tasks.named { "Ktlint" in it && "Check" in it }.configureEach {
3031
dependsOn(
31-
tasks.generateBuildConfig,
32+
tasks.generateBuildConfigClasses,
3233
"runKtlintFormatOver${buildConfigSources.name.uppercaseFirstChar()}SourceSet",
3334
)
3435
}

build-settings-logic/settings.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ pluginManagement {
1717
// versions should be kept in sync with `gradle/libs.versions.toml`
1818
plugins {
1919
// cannot be applied here, it's an early-evaluated included build
20-
id("dev.panuszewski.typesafe-conventions") version "0.10.0" apply false
20+
id("dev.panuszewski.typesafe-conventions") version "0.10.1" apply false
2121
id("org.gradle.toolchains.foojay-resolver-convention") version "1.0.0"
2222
}
2323

build-settings-logic/src/main/kotlin/dfsettings.base.settings.gradle.kts

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,5 @@
1+
@file:Suppress("UnstableApiUsage")
2+
13
val jupyterApiTCRepo: String? by settings
24

35
dependencyResolutionManagement {
Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,11 +1,9 @@
1-
import dev.panuszewski.gradle.TypesafeConventionsExtension
2-
31
plugins {
42
id("dfsettings.catalogs")
53
id("dev.panuszewski.typesafe-conventions")
64
}
75

8-
extensions.getByType<TypesafeConventionsExtension>().apply {
6+
typesafeConventions {
97
// prevents convention plugins being applied as `dependencies { implementation() }`
108
autoPluginDependencies = false
119
}

core/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -272,7 +272,7 @@ tasks.withType<Jar> {
272272
}
273273

274274
tasks.processKDocsMain {
275-
dependsOn(tasks.generateKeywordsSrc, tasks.generateBuildConfig)
275+
dependsOn(tasks.generateKeywordsSrc, tasks.generateBuildConfigClasses)
276276
}
277277

278278
tasks.runKtlintFormatOverMainSourceSet {

examples/projects/android-example/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

examples/projects/dev/android-example/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

examples/projects/dev/kotlin-dataframe-plugin-gradle-example/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

examples/projects/dev/movies/gradle/wrapper/gradle-wrapper.properties

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
distributionBase=GRADLE_USER_HOME
22
distributionPath=wrapper/dists
3-
distributionUrl=https\://services.gradle.org/distributions/gradle-9.3.1-bin.zip
3+
distributionUrl=https\://services.gradle.org/distributions/gradle-9.5.0-bin.zip
44
networkTimeout=10000
55
validateDistributionUrl=true
66
zipStoreBase=GRADLE_USER_HOME

0 commit comments

Comments
 (0)