PoC: DF without SupportedDataFrameFormat#1858
Draft
Jolanrensen wants to merge 1 commit into
Draft
Conversation
zaleslaw
reviewed
May 29, 2026
| @Test | ||
| fun `sort by nested column`() { | ||
| val df = testResource("ds_salaries.csv").readDataFrame().cast<DsSalaries>() | ||
| val df = DataFrame.readCsv(testResource("ds_salaries.csv")).cast<DsSalaries>() |
| @Test | ||
| fun `Sorted grouped iris dataset`() { | ||
| val irisData = DataFrame.read("src/test/resources/irisDataset.csv") | ||
| val irisData = DataFrame.readCsv("src/test/resources/irisDataset.csv") |
Collaborator
There was a problem hiding this comment.
readCsv is better to me rather than read(....csv)
Collaborator
Author
There was a problem hiding this comment.
it is safer, for sure, but I do like the idea of just pointing dataframe to a file and letting it "figure it out"
| import java.nio.file.Path | ||
|
|
||
| // TODO: https://github.com/Kotlin/dataframe/issues/450 | ||
| public class Jdbc : |
Collaborator
There was a problem hiding this comment.
Make no sense for JDBC, it's readFROMFILE
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#450 @zaleslaw
Simple proof-of-concept to see what DF without
DataFrame.read()andSupportedDataFrameFormatwould look like. We don't really need it after removing the KSP/Gradle. The only thing we would lose is theDataFrame.read()function.Creating the PR, I did see a lot of examples where this function was used, so maybe entirely removing it is not the best approach.
DataFrame.read()may still have a place in the library to read data instance. It's common practice in other DataFrame-like libraries in other ecosystems. But I do believe we should lean more into the dynamically typed approach if we do want to keep it. So, acceptingAny, accepting custom properties, etc.If we do remove it, we should probably also refactor
SupportedCodeGenerationFormat, because it's tightly interwoven between OpenAPI() andimportDataSchema()in notebooks.