Skip to content

Commit 26f3f19

Browse files
committed
let workflow_dispatch run the ecosystem job (experiment)
1 parent a70f81f commit 26f3f19

1 file changed

Lines changed: 4 additions & 12 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 4 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -615,20 +615,16 @@ jobs:
615615
needs: determine_changes
616616
# Only runs on pull requests, since that is the only we way we can find the base version for comparison.
617617
# Ecosystem check needs linter and/or formatter changes.
618-
if: |
619-
!contains(github.event.pull_request.labels.*.name, 'no-test') && github.event_name == 'pull_request' &&
620-
(
621-
needs.determine_changes.outputs.linter == 'true' ||
622-
needs.determine_changes.outputs.formatter == 'true'
623-
)
624-
timeout-minutes: 20
625618
env:
626619
# Line-tables-only debug info: faster builds, backtraces still work.
627620
CARGO_PROFILE_DEV_DEBUG: line-tables-only
628621
steps:
629622
- uses: actions/checkout@de0fac2e4500dabe0009e67214ff5f5447ce83dd # v6.0.2
630623
with:
631-
ref: ${{ github.event.pull_request.base.ref }}
624+
# on workflow_dispatch there is no PR base; fall back to the dispatched
625+
# branch so baseline == comparison (we just want to see if the binary
626+
# errors on the corpus)
627+
ref: ${{ github.ref_name }}
632628
persist-credentials: false
633629

634630
- uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0
@@ -666,7 +662,6 @@ jobs:
666662
uv pip install ./python/ruff-ecosystem
667663
668664
- name: Run `ruff check` stable ecosystem check
669-
if: ${{ needs.determine_changes.outputs.linter == 'true' }}
670665
run: |
671666
# Set pipefail to avoid hiding errors with tee
672667
set -eo pipefail
@@ -679,7 +674,6 @@ jobs:
679674
echo "" >> ecosystem-result
680675
681676
- name: Run `ruff check` preview ecosystem check
682-
if: ${{ needs.determine_changes.outputs.linter == 'true' }}
683677
run: |
684678
# Set pipefail to avoid hiding errors with tee
685679
set -eo pipefail
@@ -692,7 +686,6 @@ jobs:
692686
echo "" >> ecosystem-result
693687
694688
- name: Run `ruff format` stable ecosystem check
695-
if: ${{ needs.determine_changes.outputs.formatter == 'true' }}
696689
run: |
697690
# Set pipefail to avoid hiding errors with tee
698691
set -eo pipefail
@@ -705,7 +698,6 @@ jobs:
705698
echo "" >> ecosystem-result
706699
707700
- name: Run `ruff format` preview ecosystem check
708-
if: ${{ needs.determine_changes.outputs.formatter == 'true' }}
709701
run: |
710702
# Set pipefail to avoid hiding errors with tee
711703
set -eo pipefail

0 commit comments

Comments
 (0)