Skip to content

Commit d7e766a

Browse files
committed
ci: drop cargo-publish-dry-run, bump fork test-job timeouts
- remove the cargo-publish-dry-run job (upstream re-added it in a non-conflicting merge region; the fork had deleted it). the fork keeps ruff/ty crate versions in lock-step with astral's crates.io versions but modifies their apis, so `cargo publish --dry-run` resolves a published crate for a transitive dep and fails on api skew. the fork publishes only the basedpython wheel to pypi, never these crates - bump cargo-test-linux and cargo-test-(windows/macos) timeouts 20 -> 45 min: the merged test count overruns the depot-tuned 20-minute budget on the fork's slower ubuntu-latest/windows-latest runners (both timed out mid-suite)
1 parent 4a11c25 commit d7e766a

1 file changed

Lines changed: 11 additions & 17 deletions

File tree

.github/workflows/ci.yaml

Lines changed: 11 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -301,28 +301,20 @@ jobs:
301301
- name: "Clippy (wasm)"
302302
run: cargo clippy -p ruff_wasm -p ty_wasm --target wasm32-unknown-unknown --all-features --locked -- -D warnings
303303

304-
cargo-publish-dry-run:
305-
name: "cargo publish dry-run"
306-
runs-on: ${{ github.repository == 'astral-sh/ruff' && 'depot-ubuntu-22.04-8' || 'ubuntu-latest' }}
307-
needs: determine_changes
308-
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }}
309-
timeout-minutes: 20
310-
steps:
311-
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # v7.0.0
312-
with:
313-
persist-credentials: false
314-
- uses: Swatinem/rust-cache@c19371144df3bb44fab255c43d04cbc2ab54d1c4 # v2.9.1
315-
with:
316-
save-if: ${{ github.ref == 'refs/heads/main' }}
317-
- name: "cargo publish dry-run"
318-
run: cargo publish --workspace --dry-run
304+
# upstream's `cargo-publish-dry-run` is dropped: the fork keeps ruff/ty crate
305+
# versions in lock-step with astral's published crates.io versions but modifies
306+
# their apis, so `cargo publish --dry-run` pulls the real published crate for a
307+
# transitive dep and fails on the api skew. the fork publishes only the
308+
# `basedpython` wheel to pypi, never these crates to crates.io
319309

320310
cargo-test-linux:
321311
name: "cargo test (linux)"
322312
runs-on: ${{ github.repository == 'astral-sh/ruff' && 'depot-ubuntu-22.04-16' || 'ubuntu-latest' }}
323313
needs: determine_changes
324314
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }}
325-
timeout-minutes: 20
315+
# the fork's `ubuntu-latest` runner is far slower than astral's 16-core depot
316+
# runner, so the full suite overruns the depot-tuned 20-minute budget
317+
timeout-minutes: 45
326318
env:
327319
# Line-tables-only debug info: faster builds, backtraces still work.
328320
CARGO_PROFILE_DEV_DEBUG: line-tables-only
@@ -431,7 +423,9 @@ jobs:
431423
runs-on: ${{ matrix.platform }}
432424
needs: determine_changes
433425
if: ${{ !contains(github.event.pull_request.labels.*.name, 'no-test') && (needs.determine_changes.outputs.code == 'true' || github.ref == 'refs/heads/main') }}
434-
timeout-minutes: 20
426+
# the fork's `windows-latest`/`macos-latest` runners are slower than astral's
427+
# depot runners, so the full suite overruns the depot-tuned 20-minute budget
428+
timeout-minutes: 45
435429
env:
436430
# Line-tables-only debug info: faster builds, backtraces still work.
437431
CARGO_PROFILE_DEV_DEBUG: line-tables-only

0 commit comments

Comments
 (0)