Add new lint rules

Author: liZe

cssselect2/tree.py

@@ -305,14 +305,14 @@ def etree_children(self):
     def local_name(self):
         """The local name of this element, as a string."""
         namespace_url, local_name = _split_etree_tag(self.etree_element.tag)
-        self.__dict__[str('namespace_url')] = namespace_url
+        self.__dict__['namespace_url'] = namespace_url
         return local_name
 
     @cached_property
     def namespace_url(self):
         """The namespace URL of this element, as a string."""
         namespace_url, local_name = _split_etree_tag(self.etree_element.tag)
-        self.__dict__[str('local_name')] = local_name
+        self.__dict__['local_name'] = local_name
         return namespace_url
 
     @cached_property

docs/example.py

@@ -34,15 +34,14 @@
 wrapper = cssselect2.ElementWrapper.from_html_root(html_tree)
 for element in wrapper.iter_subtree():
     tag = element.etree_element.tag.split('}')[-1]
-    print('Found tag "{}" in HTML'.format(tag))
+    print(f'Found tag "{tag}" in HTML')
 
     matches = matcher.match(element)
     if matches:
         for match in matches:
             specificity, order, pseudo, payload = match
             selector_string, content_string = payload
-            print('Matching selector "{}" ({})'.format(
-                selector_string, content_string))
+            print(f'Matching selector "{selector_string}" ({content_string})')
     else:
         print('No rule matching this tag')
     print()

pyproject.toml

@@ -55,8 +55,12 @@ exclude_lines = ['pragma: no cover', 'def __repr__', 'raise NotImplementedError'
 omit = ['.*']
 
 [tool.ruff.lint]
-select = ['E', 'W', 'F', 'I', 'N', 'RUF']
+select = ['E', 'W', 'F', 'I', 'N', 'RUF', 'T20', 'PIE', 'PT', 'RSE', 'UP', 'Q']
 ignore = ['RUF001', 'RUF002', 'RUF003']
 
+[tool.ruff.lint.flake8-quotes]
+inline-quotes = 'single'
+multiline-quotes = 'single'
+
 [tool.ruff.lint.extend-per-file-ignores]
-'docs/example.py' = ['I001']
+'docs/example.py' = ['I001', 'T201']

tests/test_cssselect2.py

@@ -119,7 +119,7 @@ def test_lang():
     assert not root.matches(':lang(en)')
 
 
-@pytest.mark.parametrize('selector, result', (
+@pytest.mark.parametrize(('selector', 'result'), [
     ('*', ALL_IDS),
     ('div', ['outer-div', 'li-div', 'foobar-div']),
     ('div div', ['li-div']),
@@ -228,7 +228,6 @@ def test_lang():
     ('*#first-li', ['first-li']),
     ('li div', ['li-div']),
     ('li > div', ['li-div']),
-    ('div div', ['li-div']),
     ('div > div', []),
     ('div>.c', ['first-ol']),
     ('div > .c', ['first-ol']),
@@ -320,7 +319,7 @@ def test_lang():
     ('/* test */a:not([href])/* test */,div  div', ['name-anchor', 'li-div']),
     ('/* test */ a:not([href]), div/* test */ div', ['name-anchor', 'li-div']),
     ('a:not([href]) /* test */,/* test */div  div', ['name-anchor', 'li-div']),
-))
+])
 def test_select(selector, result):
     xml_ids = [
         element.etree_element.get('id', 'nil') for element in
@@ -331,12 +330,12 @@ def test_select(selector, result):
     assert xml_ids == html_ids == result
 
 
-@pytest.mark.parametrize('selector, result', (
+@pytest.mark.parametrize(('selector', 'result'), [
     ('DIV', ['outer-div', 'li-div', 'foobar-div']),
     ('a[NAme]', ['name-anchor']),
     ('HTML :link', [
         'link-href', 'tag-anchor', 'nofollow-anchor', 'area-href']),
-))
+])
 def test_html_select(selector, result):
     assert not [
         element.etree_element.get('id', 'nil') for element in
@@ -347,7 +346,7 @@ def test_html_select(selector, result):
 
 
 # Data borrowed from http://mootools.net/slickspeed/
-@pytest.mark.parametrize('selector, result', (
+@pytest.mark.parametrize(('selector', 'result'), [
     # Changed from original because we’re only searching the body.
     # ('*', 252),
     ('*', 246),
@@ -396,6 +395,6 @@ def test_html_select(selector, result):
     ('div[class|=dialog]', 50),  # ? Seems right
     # assert count('div[class!=madeup]', 243),  # ? Seems right
     ('div[class~=dialog]', 51),  # ? Seems right
-))
+])
 def test_select_shakespeare(selector, result):
     assert sum(1 for _ in SHAKESPEARE_BODY.query_all(selector)) == result