[GeoMechanicsApplication] Let the K0 procedure process also accept GEO_FRICTION_ANGLE as optional input by markelov208 · Pull Request #14352 · KratosMultiphysics/Kratos

markelov208 · 2026-04-10T09:34:49Z

📝 Description

A brief description of the PR.

added check for GEO_FRICTION_ANGLE in ApplyK0ProcedureProcess
added two helper functions: HasFrictionAngle and ValidateFrictionAngle in ConstitutiveLawUtilities
added unit tests for these functions
added description of GEO_FRICTION_ANGLE use in README.md

WPK4FEM

Hi Gennady,
Thank you for your fast actions on this matter, I think it almost ready to go ( but I still need to look better at the unit tests ).
Please have a look at the remark of switching the order of check GEO_FRICTION_ANGLE and the UMAT stuff.
Thank you, Wijtze Pieter

markelov208 · 2026-04-10T09:58:03Z

Hi Gennady, Thank you for your fast actions on this matter, I think it almost ready to go ( but I still need to look better at the unit tests ). Please have a look at the remark of switching the order of check GEO_FRICTION_ANGLE and the UMAT stuff. Thank you, Wijtze Pieter

Hi Wijtze Pieter, unit tests are coming. The order, what shall be check first? GEO_FRICTION_ANGLE?

WPK4FEM

Hi Gennady,

Thank you for completing the functionality and fixing my spelling mistakes. I have one request to avoid repetition of the phi bounds check in the constitutive_law_utitlities. Otherwise I think this is good to go.

Regards, Wijtze Pieter

WPK4FEM · 2026-04-13T06:53:43Z

+        KRATOS_ERROR_IF(phi < 0.0 || phi > 90.0)
+            << "GEO_FRICTION_ANGLE (" << phi << ") should be between 0 and 90 degrees for element "
+            << ElementId << "." << std::endl;


This check also appear on lines 114 to 116. I would propose do the domain check [0, 90] after the if statement is completed.

Suggested change

KRATOS_ERROR_IF(phi < 0.0 || phi > 90.0)

<< "GEO_FRICTION_ANGLE (" << phi << ") should be between 0 and 90 degrees for element "

<< ElementId << "." << std::endl;

double phi;

if (rProperties.Has(GEO_FRICTION_ANGLE)){

phi = ;

} else if (rProperties.Has(INDEX_OF_UMAT_PHI_PARAMETER) || rProperties.Has(UMAT_PARAMETERS)){

phi = ;

} else {

error ;

}

KRATOS_ERROR_IF( phi < 0.0 || phi > 90.0 ) ....

I've made almost as you proposed. I've also removed a duplication in a similar situation in apply_k0_process.

markelov208

Hi Wijtze Pieter, thank you very much for the prompt review.

markelov208 · 2026-04-13T12:37:19Z

+        KRATOS_ERROR_IF(phi < 0.0 || phi > 90.0)
+            << "GEO_FRICTION_ANGLE (" << phi << ") should be between 0 and 90 degrees for element "
+            << ElementId << "." << std::endl;


I've made almost as you proposed. I've also removed a duplication in a similar situation in apply_k0_process.

WPK4FEM

Thank you for the better checking. Sorry that I have more nagging when re-reading.
Regards, Wijtze Pieter

WPK4FEM · 2026-04-13T12:46:41Z

+    std::ostringstream valid_values;
+    for (std::size_t i = 0; i < dimension; ++i) {
+        if (i > 0) {
+            if (i == dimension - 1) valid_values << " or ";
+            else valid_values << ", ";
+        }
+        valid_values << i;


This looks like a valid thing to do, but I have some doubts. Plane strain is a 2D analysis, but it still has 3 normal stress components and the K0_MAIN_DIRECTION can be any of 1, 2, or 3 ( out of plane ).
For plane stress analysis, where you have only in plane stresses and it really is a 2D thing, you would be right. However geo-mechanics is plane strain or three-dimensional analysis and hardly ever plane stress analysis.

WPK4FEM · 2026-04-13T12:51:14Z

+
+        KRATOS_ERROR_IF(phi_index < 1 || phi_index > number_of_umat_parameters)
+            << "INDEX_OF_UMAT_PHI_PARAMETER (" << phi_index
+            << ") is not in range [1, size of UMAT_PARAMETERS] for element " << ElementId << "."


The property Id would be more helpful to the user here than the element Id. With the property Id, you can directly find the input. For an element you would first need to look up the property Id used for that element, before you can fix the mistake.
If very precise, we could print both element and property Id in the message.

added prints of property Id.

WPK4FEM · 2026-04-13T12:52:40Z

+    KRATOS_ERROR_IF(phi < 0.0 || phi > 90.0)
+        << phi_name << " (" << phi << ") should be between 0 and 90 degrees for element "
+        << ElementId << "." << std::endl;


Same remark as the previous about the property Id being more useful than the element Id.
Otherwise this structure is exactly what I asked for, thank you.

added prints of property Id.

WPK4FEM

For me this is complete.
Thank you,
Wijtze Pieter

added HasFrictionAngle and ValidateFrictionAngle

c7a6e6f

markelov208 self-assigned this Apr 10, 2026

markelov208 requested a review from a team as a code owner April 10, 2026 09:34

WPK4FEM reviewed Apr 10, 2026

View reviewed changes

added unit tests for HasFrictionAngle and ValidateFrictionAngle

25d93dc

markelov208 added 3 commits April 10, 2026 12:03

changed order of getting friction angle

6f94227

updated README.md

f42558a

excluded check of friction angle when k0 values are available

7ded4ea

markelov208 requested review from WPK4FEM and avdg81 April 10, 2026 12:56

markelov208 added 5 commits April 10, 2026 20:17

removed {} in unit tests

f273ae9

used Kratos style for local variables

47273e7

added unit test K0ProcedureIsAppliedCorrectlyWithK0_Values_3D

cd932d0

minor changes

a650c0d

fixed typo

0e767b7

markelov208 linked an issue Apr 12, 2026 that may be closed by this pull request

[GeoMechanicsApplication] Let the K0 procedure process also accept GEO_FRICTION_ANGLE as optional input #14351

Closed

WPK4FEM reviewed Apr 13, 2026

View reviewed changes

markelov208 added 4 commits April 13, 2026 11:05

response to the review

bd5b3a8

response to the review comment

a4dfcfc

fixed a type mismatch

df75c0f

fixed check

f3186e2

markelov208 commented Apr 13, 2026

View reviewed changes

markelov208 requested a review from WPK4FEM April 13, 2026 12:39

WPK4FEM reviewed Apr 13, 2026

View reviewed changes

markelov208 added 4 commits April 13, 2026 15:11

added property Id in output

48508d6

added more prints of property Id

5ad2167

added even more prints of property Id

9e2a625

fixed a type mismatch

da7cf16

markelov208 requested a review from WPK4FEM April 14, 2026 07:31

WPK4FEM approved these changes Apr 14, 2026

View reviewed changes

markelov208 merged commit 72cf280 into master Apr 14, 2026
10 checks passed

markelov208 deleted the geo/14351-GEO_FRICTION_ANGLE-in-K0 branch April 14, 2026 08:55

-        KRATOS_ERROR_IF(phi < 0.0 || phi > 90.0)
-            << "GEO_FRICTION_ANGLE (" << phi << ") should be between 0 and 90 degrees for element "
-            << ElementId << "." << std::endl;
+        double phi;
+        if (rProperties.Has(GEO_FRICTION_ANGLE)){
+            phi = ;
+        } else if (rProperties.Has(INDEX_OF_UMAT_PHI_PARAMETER) || rProperties.Has(UMAT_PARAMETERS)){
+            phi = ;
+        } else {
+            error ;
+        }
+        KRATOS_ERROR_IF( phi < 0.0 || phi > 90.0 ) ....

Conversation

markelov208 commented Apr 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Description

Uh oh!

WPK4FEM left a comment

Choose a reason for hiding this comment

Uh oh!

markelov208 commented Apr 10, 2026

Uh oh!

WPK4FEM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

markelov208 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

WPK4FEM left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

WPK4FEM left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

markelov208 commented Apr 10, 2026 •

edited

Loading