Add the concept of priorities to TSMessages#103
Open
srekke wants to merge 2 commits into
Open
Conversation
- Messages are presented in order of their priority - This happens by sorting the messages list just before "fading in" a new message - If there are no differences in priority, the order stays the same
Owner
|
This looks amazing! I'll take a look and test it! 👍 |
Contributor
Author
|
I just noticed that I accidentally included the NSCopying additions I made to this pull request. They are a requirement for another (but related) feature I am working on. If you want, I could create a separate pull request for it? |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
One does not need to use this new functionality; calling the original initialization methods without a priority will result in a normal priority. Note that previously a fadeOut always removed the first object in messages. I've changed this to always remove the object being faded (which should be the first). This is not essential to the new feature, but I thought it made sense with these changes.
Hi Felix,
This is something I did for my own project that uses TSMessages. Care to have a look and let me know if you think it's worth to merge this?
Thanks!
Steven