Skip to content

Fix bug: User tap on notif banner with callback cannot dismiss it #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Kjuly wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix bug: User tap on notif banner with callback cannot dismiss it #193

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions Pod/Classes/TSMessageView.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,10 +343,12 @@ - (id)initWithTitle:(NSString *)title
UISwipeGestureRecognizerDirectionUp :
UISwipeGestureRecognizerDirectionDown)];
[self addGestureRecognizer:gestureRec];

UITapGestureRecognizer *tapRec = [[UITapGestureRecognizer alloc] initWithTarget:self
action:@selector(fadeMeOut)];
[self addGestureRecognizer:tapRec];

if (! self.callback) {
UITapGestureRecognizer *tapRec = [[UITapGestureRecognizer alloc] initWithTarget:self
action:@selector(fadeMeOut)];
[self addGestureRecognizer:tapRec];
}
}

if (self.callback) {
Expand Down Expand Up @@ -507,6 +509,7 @@ - (void)handleTap:(UITapGestureRecognizer *)tapGesture
self.callback();
}
}
[self fadeMeOut];
}

#pragma mark - UIGestureRecognizerDelegate
Expand Down