Add async analyzers and error on missing ConfigureAwait

Author: Krusen

BencodeNET/BencodeNET.csproj

@@ -4,6 +4,7 @@
     <TargetFrameworks>netstandard1.3;netstandard2.0;netcoreapp2.1</TargetFrameworks>
     <LangVersion>7.3</LangVersion>
     <GenerateDocumentationFile>True</GenerateDocumentationFile>
+    <CodeAnalysisRuleSet>BencodeNET.ruleset</CodeAnalysisRuleSet>
   </PropertyGroup>
 
   <!-- Needed for code coverage -->
@@ -36,6 +37,7 @@
 
   <ItemGroup>
     <PackageReference Include="System.IO.Pipelines" Version="4.5.3" />
+    <PackageReference Include="Microsoft.VisualStudio.Threading.Analyzers" Version="16.3.52" PrivateAssets="All" />
   </ItemGroup>
 
   <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' ">

BencodeNET/BencodeNET.ruleset

@@ -0,0 +1,10 @@
+<?xml version="1.0" encoding="utf-8"?>
+<RuleSet Name="Microsoft Managed Recommended Rules" Description="These rules focus on the most critical problems in your code, including potential security holes, application crashes, and other important logic and design errors. It is recommended to include this rule set in any custom rule set you create for your projects." ToolsVersion="10.0">
+  <Localization ResourceAssembly="Microsoft.VisualStudio.CodeAnalysis.RuleSets.Strings.dll" ResourceBaseName="Microsoft.VisualStudio.CodeAnalysis.RuleSets.Strings.Localized">
+    <Name Resource="MinimumRecommendedRules_Name" />
+    <Description Resource="MinimumRecommendedRules_Description" />
+  </Localization>
+  <Rules AnalyzerId="Microsoft.VisualStudio.Threading.Analyzers" RuleNamespace="Microsoft.VisualStudio.Threading.Analyzers">
+    <Rule Id="VSTHRD111" Action="Error" />
+  </Rules>
+</RuleSet>

BencodeNET/Torrents/TorrentParser.cs

@@ -1,4 +1,4 @@
-using System;
+using System;
 using System.Collections.Generic;
 using System.Linq;
 using System.Text;
@@ -90,7 +90,7 @@ public override Torrent Parse(BencodeReader reader)
         /// <returns>The parsed <see cref="Torrent"/>.</returns>
         public override async ValueTask<Torrent> ParseAsync(PipeBencodeReader pipeReader, CancellationToken cancellationToken = default)
         {
-            var data = await BencodeParser.ParseAsync<BDictionary>(pipeReader, cancellationToken);
+            var data = await BencodeParser.ParseAsync<BDictionary>(pipeReader, cancellationToken).ConfigureAwait(false);
             return CreateTorrent(data);
         }