Feature: CSV import#2612
Open
denisps wants to merge 15 commits into
Open
Conversation
…atch the project style.
…n to 1.5.2 as it was conflicting with all build.gradle minSdkVersion 19
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…vented showActionErrorIfNeeded from ever be called, switched to using dedicated showError instead of generic Toast, and removed unnecessary success message for CSV import task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I implemented CSV import feature that automatically detects and maps CSV fields for Chrome's and Firefox's passwords. Additionally, I refactored and fixed a minor bag in GroupActivity.kt onDatabaseActionFinished, that would never display an error message on error as it was placed in a isSuccess path. For CSV import feature, I generated translated strings for all supported languages.
AI disclosure. I used Gemini Flash and Claude Sonnet and assistive agents for initial implementation and human guided refactoring, and used GPT-5.4 for generating string translations for all supported languages.
I tested the implementation on x86 Emulator and Samsung S25 Ultra importing test csv files and my own passwords.
The implementation was cleaned up and refactored to use project's code style and UI styling to the best of my understanding.
Please let me know if there is anything you would like me to adjust or correct.