Skip to content

refactor: change route spec backup and condition extension anno key #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zoumo merged 1 commit into from
Jul 27, 2025
+10 −9
Merged

refactor: change route spec backup and condition extension anno key #38

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions rollout/v1alpha1/shared_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,11 +118,11 @@ type BatchProgressingInfo struct {
}

const (
RouteConditionTypeReady = "Ready"
RouteConditionTypeSynced = "Synced"
ConditionTypeReady = "Ready"
ConditionTypeSynced = "Synced"
)

// RouteConditionExtension contains the conditions of route
type RouteConditionExtension struct {
// ConditionExtension contains the conditions of route
type ConditionExtension struct {
Conditions []metav1.Condition `json:"conditions,omitempty"`
}
11 changes: 6 additions & 5 deletions rollout/well_known_annotations.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,11 @@ const (
AnnoRolloutName = "rollout.kusionstack.io/name"
)

// traffic annotations
// new style key
const (
// AnnoRouteSpecBackup is the origin spec of route object. It is used to rollback.
AnnoRouteSpecBackup = "rollout.kusionstack.io/route-spec-backup"
// AnnoRouteConditions is the conditions of route object.
AnnoRouteConditions = "rollout.kusionstack.io/route-conditions"
// OriginRouteSpecAnnoKey is the backup of origin route object spec. It is used to rollback.
OriginRouteSpecAnnoKey = "rollout.kusionstack.io/origin-route-spec"

// AnnoConditionExtension is the annotation key of condition extension.
ConditionExtensionAnnoKey = "rollout.kusionstack.io/condition-extension"
)
Loading