add inactive targets

Author: ColdsteelRail

xset/api/xset_controller_types.go

@@ -57,12 +57,16 @@ type XOperation interface {
 	CheckScheduled(object client.Object) bool
 	CheckReadyTime(object client.Object) (bool, *metav1.Time)
 	CheckAvailable(object client.Object) bool
+	CheckInactive(object client.Object) bool
 	GetXOpsPriority(ctx context.Context, c client.Client, object client.Object) (*OpsPriority, error)
 }
 
 type SubResourcePvcAdapter interface {
-	XSetPvcTemplate(object XSetObject) []corev1.PersistentVolumeClaim
-	XMountedPvcs(object client.Object)
+	RetainPvcWhenXSetDeleted(object XSetObject) bool
+	RetainPvcWhenXSetScaled(object XSetObject) bool
+	GetXSetPvcTemplate(object XSetObject) []corev1.PersistentVolumeClaim
+	GetXMountedPvcs(object client.Object) []corev1.Volume
+	MountXPvcs(object client.Object, pvcs []corev1.Volume)
 }
 
 // LifecycleAdapterGetter is used to get lifecycle adapters.

xset/xcontrol/target_control.go

@@ -97,7 +97,7 @@ func (r *targetControl) GetFilteredTargets(ctx context.Context, selector *metav1
 		return nil, fmt.Errorf("target list items is invalid")
 	}
 
-	// todo filterOutInactiveTargets
+	items = filterOutInactiveTargets(r.xsetController, items)
 	targets, err := r.getTargets(items, selector, owner)
 	return targets, err
 }
@@ -199,3 +199,14 @@ func setUpCache(cache cache.Cache, controller api.XSetController) error {
 	}
 	return nil
 }
+
+func filterOutInactiveTargets(xsetController api.XSetController, targets []client.Object) []client.Object {
+	var filteredTarget []client.Object
+	for i := range targets {
+		target := targets[i]
+		if xsetController.CheckInactive(target) {
+			filteredTarget = append(filteredTarget, target)
+		}
+	}
+	return filteredTarget
+}