Skip to content

refactor refactor-NewInPlaceOnlyUpdaterFunc #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ColdsteelRail merged 1 commit into from
Jan 27, 2026
+4 −4
Merged

refactor refactor-NewInPlaceOnlyUpdaterFunc #29

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions synccontrols/x_update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,11 +332,11 @@ type TargetUpdater interface {
FinishUpdateTarget(ctx context.Context, targetInfo *TargetUpdateInfo, finishByCancelUpdate bool) error
}

var NewInPlaceOnlyPossibleUpdaterFunc func() TargetUpdater
var NewInPlaceOnlyUpdaterFunc func() TargetUpdater

// RegisterInPlaceOnlyUpdater Support users to define inPlaceOnlyTargetUpdater and register through RegisterInPlaceOnlyUpdater
func RegisterInPlaceOnlyUpdater(f func() TargetUpdater) {
NewInPlaceOnlyPossibleUpdaterFunc = f
NewInPlaceOnlyUpdaterFunc = f
}

var NewInPlaceIfPossibleUpdaterFunc func() TargetUpdater
Expand All @@ -353,8 +353,8 @@ func (r *RealSyncControl) newTargetUpdater(xset api.XSetObject) TargetUpdater {
case api.XSetRecreateTargetUpdateStrategyType:
targetUpdater = &recreateTargetUpdater{}
case api.XSetInPlaceOnlyTargetUpdateStrategyType:
if NewInPlaceOnlyPossibleUpdaterFunc != nil {
targetUpdater = NewInPlaceOnlyPossibleUpdaterFunc()
if NewInPlaceOnlyUpdaterFunc != nil {
targetUpdater = NewInPlaceOnlyUpdaterFunc()
} else if NewInPlaceIfPossibleUpdaterFunc != nil {
// In case of using native K8s, Target is only allowed to update with container image, so InPlaceOnly policy is
// implemented with InPlaceIfPossible policy as default for compatibility.
Expand Down
Loading